Opened 12 years ago

Closed 10 years ago

#11357 closed enhancement (invalid)

[patch] [cla] dojox.form.manager - some mixin optimizations

Reported by: ben hockey Owned by: Eugene Lazutkin
Priority: high Milestone: 1.8
Component: DojoX Form Version: 1.5.0b2
Keywords: Cc:
Blocked By: Blocking:


the attached patch shows how some of the code in dojox.form.manager._Mixin and dojox.form.manager._NodeMixin could be optimized.

Attachments (1)

11357.diff (2.0 KB) - added by ben hockey 12 years ago.

Download all attachments as: .zip

Change History (4)

Changed 12 years ago by ben hockey

Attachment: 11357.diff added

comment:1 Changed 12 years ago by Eugene Lazutkin

Milestone: tbdfuture
Owner: changed from dante to Eugene Lazutkin
Status: newassigned

comment:2 Changed 10 years ago by Kris Zyp

In [26679]:

Properly record observe handle and get onSet notifications refs #11357 !strict

comment:3 Changed 10 years ago by Eugene Lazutkin

Milestone: future1.8
Resolution: invalid
Status: assignedclosed

The round-about method to get all observer names is to remove duplicates. The proposed patch allows duplicates of observers. For now I reject the patch because it changes the logic significantly and potently may cause some observers to be processed multiple times.

Note: See TracTickets for help on using tickets.