Opened 9 years ago
Closed 9 years ago
#11346 closed defect (fixed)
Dialog: cancel button executes dialog instead of canceling it
| Reported by: | Scott Moore | Owned by: | bill |
|---|---|---|---|
| Priority: | high | Milestone: | 1.5 |
| Component: | Dijit | Version: | 1.4.3 |
| Keywords: | dijit Dialog Action Buttons Cancel | Cc: | |
| Blocked By: | Blocking: |
Description (last modified by )
I am looking at the test
http://archive.dojotoolkit.org/nightly/dojotoolkit/dijit/tests/test_Dialog.html
When I click on the "Show Dialog with Action Buttons" and I hit the Cancel button, it appears to fire the Ok button event. I am not sure if the test is bad or if there is a bug in the Dialog itself.
Attachments (1)
Change History (5)
comment:1 Changed 9 years ago by
| Component: | General → Dijit |
|---|---|
| Owner: | anonymous deleted |
comment:2 Changed 9 years ago by
| Description: | modified (diff) |
|---|---|
| Milestone: | tbd → 1.5 |
| Owner: | set to bill |
| Status: | new → assigned |
| Summary: | dijit.Dialog with Action Buttons always fires Execute but not cancel → Dialog: cancel button executes dialog instead of canceling it |
comment:3 Changed 9 years ago by
Turns out that type=cancel won't fly on IE8, at least for <button> tags. It shows up as type=submit. So I'll just update the test case and documentation to use a <button type=button> with an onClick handler to close the dialog.
Changed 9 years ago by
| Attachment: | cancelButton.patch added |
|---|
patch for type=cancel support on Buttons, except that parser on IE8 can't handle it
Note: See
TracTickets for help on using
tickets.
Hmm, you are right, I think it's both a problem with the test and a problem with the code. The test has type=submit for the Cancel button. I guess it should be type=cancel, although there's no such type as part of the HTML spec. That's how I documented it in the release notes.
More like a missing feature, technically.