Opened 10 years ago

Closed 5 years ago

Last modified 5 years ago

#11344 closed enhancement (fixed)

[patch][cla] dojox.rpc.Service - option to allow sync calls

Reported by: Daniel Stefaniuk Owned by: dylan
Priority: low Milestone: 1.11
Component: RPC Version: 1.5.0b2
Keywords: rpc, service needsreview Cc:
Blocked By: Blocking:

Description

Service doesn't have an option to allow synchronized calls back to server. Adding 'sync' option to the second argument of constructor should have an impact how the service behave.

Attachments (1)

Service.diff​ (627 bytes) - added by Daniel Stefaniuk 10 years ago.

Download all attachments as: .zip

Change History (10)

Changed 10 years ago by Daniel Stefaniuk

Attachment: Service.diff​ added

comment:1 in reply to:  description Changed 10 years ago by Daniel Stefaniuk

As it is not very common to use synchronized calls, also a "method" setSync(/*bool*/value) could be added to the implementation of Service. This will give a possibility to switch synchronization off later on, if declared with {sync:true}.

comment:2 Changed 9 years ago by ben hockey

Keywords: needsreview added
Priority: high → low

comment:3 Changed 5 years ago by dylan

Milestone: tbd → 1.11
Owner: changed from Dustin Machi to dylan
Status: new → assigned

comment:4 Changed 5 years ago by dylans <[email protected]…>

Resolution: → fixed
Status: assigned → closed

In 85038903e7f66f3e5e10b721c08e34ddbad47059/dojox:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled?

comment:5 Changed 5 years ago by dylans <[email protected]…>

In e3299e5f765f9ac9edca09687bfff265b8224f92/dojox:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled?

comment:6 Changed 5 years ago by dylans <[email protected]…>

In a1b6badd88b98e88ca7674a33a691b72a64accdc/dojox:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled?

comment:7 Changed 5 years ago by dylans <[email protected]…>

In e9b7028cef5d6a5d5634050fb3392e2030901ef3/dojox:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled?

comment:8 Changed 5 years ago by dylans <[email protected]…>

In 72cf527fa04bd1f42073a6b78d38b6ba25337b04/dojox:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled?

comment:9 Changed 5 years ago by dylan

Landed the patch provided, thanks danstefan. Apologies that it took six years to land a one-line patch.

If you're still interested in the setSync method, we would accept a pull request ( ​https://github.com/dojo/dojo/blob/master/CONTRIBUTING.md ), and I'll review it right away this time.

Note: See TracTickets for help on using tickets.