Opened 11 years ago
Closed 6 years ago
#11335 closed defect (patchwelcome)
dojox.widget._RollerHover stops animation whenever you fire onMouseEnter and does not recover
| Reported by: | the_drow | Owned by: | dante |
|---|---|---|---|
| Priority: | low | Milestone: | 1.13 |
| Component: | DojoX Widgets | Version: | 1.5.0rc1 |
| Keywords: | Cc: | ||
| Blocked By: | Blocking: |
Description
This is very simple to recreate. Just use the dojox.widget.Roller with the dojox.widget._RollerHover mixin and hover on the Roller while the animation is running. I have fixed this and I have a patch for you guys :).
Attachments (1)
Change History (7)
Changed 11 years ago by
| Attachment: | dojox.widget._RollerHover added |
|---|
comment:1 Changed 11 years ago by
| Resolution: | → wontfix |
|---|---|
| Status: | new → closed |
please adjust for style guidelines and reopen if issue is worth escalation. I'm hesitant to change such a basic widget with undocumented functions and whatnot. what does recoveryDuration add/do? seems an edge case you've solved.
comment:2 Changed 11 years ago by
| Resolution: | wontfix |
|---|---|
| Status: | closed → reopened |
The recoveryDuration is the time that takes to fade in if you mouseover while fading out, you shouldn't just stop the animation. It doesn't make sense. Where can I find the style guidelines.
comment:4 Changed 11 years ago by
| Milestone: | tbd → future |
|---|
please adjust the patch to meet the styles outlined here: http://docs.dojocampus.org/developer/styleguide
comment:6 Changed 6 years ago by
| Milestone: | future → 1.12 |
|---|---|
| Priority: | blocker → low |
| Resolution: | → patchwelcome |
| Status: | reopened → closed |
Patch is outdated, because it was never updated to match the Dojo style guidelines. If there's interest in revisiting this, please reopen with a pull request per our contribution guidelines ( https://github.com/dojo/dojo/blob/master/CONTRIBUTING.md ).
dojox.widget._RollerHover refactored to consider recovery to the latest item displayed