Opened 9 years ago

Closed 3 years ago

#11335 closed defect (patchwelcome)

dojox.widget._RollerHover stops animation whenever you fire onMouseEnter and does not recover

Reported by: the_drow Owned by: dante
Priority: low Milestone: 1.13
Component: DojoX Widgets Version: 1.5.0rc1
Keywords: Cc:
Blocked By: Blocking:

Description

This is very simple to recreate. Just use the dojox.widget.Roller with the dojox.widget._RollerHover mixin and hover on the Roller while the animation is running. I have fixed this and I have a patch for you guys :).

Attachments (1)

dojox.widget._RollerHover (1.6 KB) - added by the_drow 9 years ago.
dojox.widget._RollerHover refactored to consider recovery to the latest item displayed

Download all attachments as: .zip

Change History (7)

Changed 9 years ago by the_drow

Attachment: dojox.widget._RollerHover added

dojox.widget._RollerHover refactored to consider recovery to the latest item displayed

comment:1 Changed 9 years ago by dante

Resolution: wontfix
Status: newclosed

please adjust for style guidelines and reopen if issue is worth escalation. I'm hesitant to change such a basic widget with undocumented functions and whatnot. what does recoveryDuration add/do? seems an edge case you've solved.

comment:2 Changed 8 years ago by the_drow

Resolution: wontfix
Status: closedreopened

The recoveryDuration is the time that takes to fade in if you mouseover while fading out, you shouldn't just stop the animation. It doesn't make sense. Where can I find the style guidelines.

comment:3 Changed 8 years ago by the_drow

Found the styling guidelines, what's wrong with what I added?

comment:4 Changed 8 years ago by dante

Milestone: tbdfuture

please adjust the patch to meet the styles outlined here: http://docs.dojocampus.org/developer/styleguide

comment:5 Changed 7 years ago by Colin Snover

Priority: highblocker

Bulk update of open ticket priorities.

comment:6 Changed 3 years ago by dylan

Milestone: future1.12
Priority: blockerlow
Resolution: patchwelcome
Status: reopenedclosed

Patch is outdated, because it was never updated to match the Dojo style guidelines. If there's interest in revisiting this, please reopen with a pull request per our contribution guidelines ( https://github.com/dojo/dojo/blob/master/CONTRIBUTING.md ).

Note: See TracTickets for help on using tickets.