Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#11333 closed defect (fixed)

Latest Flash (10.1.x) breaks dojox.form.FileUploader

Reported by: doron Owned by: Mike Wilcox
Priority: high Milestone: 1.5
Component: DojoX Uploader Version: 1.5.0b2
Keywords: Cc: Adam Peller
Blocked By: Blocking:

Description

Latest flash 10.1.x breaks dojox.form.FileUploader? - tested in 1.3, 1.4 and 1.5rc using the test file in src.

10.1 contains major security fixes and lots of folks are downloading it.

Change History (17)

comment:1 Changed 9 years ago by doron

To clear it up - you can select files using the native filepicker, but the change event from _fileInput never fires.

comment:2 Changed 9 years ago by Mike Wilcox

What breaks? What are the security fixes? Where is a site with the release notes? This seems to be a pre-release player.

comment:3 in reply to:  2 Changed 9 years ago by doron

Replying to mwilcox:

What breaks? What are the security fixes? Where is a site with the release notes? This seems to be a pre-release player.

10.1 is available as a final release from adobe.com - http://www.adobe.com/devnet/flashplayer/articles/fplayer10.1_air2_security_changes.html covers some stuff

comment:4 Changed 9 years ago by doron

FileUploader::_change is never hit in the failure case after selecting a file

comment:5 Changed 9 years ago by doron

Topic.as::publish

Seeing an error during ExternalInterface?.call.apply(null, args)

Error.toString - Error: Error #2014

comment:6 Changed 9 years ago by Mike Wilcox

2014: "The feature is not supported on this system" Man, that doesn't sound good. I wish Adobe would stop breaking existing code. That's got to be a bug, I don't see what the security issue is there.

comment:7 Changed 9 years ago by doron

After some more debugging:

var args:Array = [

"dojo.publish", MovieIdentity?.identity+"/"+event.type, [event.argObject, event.scope]

];

event.scope is the issue - if I repalce it with a string no exception. Seems event.scope is the issue.

comment:8 Changed 9 years ago by Mike Wilcox

oh, that makes sense (a little). I don't think I'm using the scope object. I write that so long ago I'm not sure.

comment:9 in reply to:  8 Changed 9 years ago by doron

Replying to mwilcox:

oh, that makes sense (a little). I don't think I'm using the scope object. I write that so long ago I'm not sure.

Removing it seems to work here. Do you know what revision of the deft code was used for dojo 1.3.x? Need to port this fix to support the uploader.swf 1.3 used (svn doesn't show any branches/tags for 1.3 for deft).

comment:10 Changed 9 years ago by Adam Peller

Milestone: tbd1.5
Priority: normalhigh
severity: normalcritical

comment:11 Changed 9 years ago by Mike Wilcox

Resolution: fixed
Status: newclosed

(In [22344]) Fixes #11333 - edited SWF to not use object scope in pub/sub. This throws an error in the beta Flash PLayer version.

comment:12 Changed 9 years ago by Mike Wilcox

Ok Doron, I committed your suggested fix. I'm not using Flash Player Beta - can you confirm the fix worked please?

comment:13 Changed 9 years ago by doron

Seems to work here - also, 10.1 is not a beta player, it was released last week (http://get.adobe.com/flashplayer)

comment:14 Changed 9 years ago by Mike Wilcox

Great, thanks for your help doron.

comment:15 Changed 9 years ago by doron

Hmm, for 1.3 I had to just do [event.argObject], else it was still failing. For 1.4 it seemes to be working fine, might want to have others test.

comment:16 Changed 9 years ago by frietsch

@doron: Is there any place where I can download a new flash object working in Dojo 1.3? We have jumped to Dojo 1.5 recently, but not with our stable product version...

Thanks a lot!

comment:17 Changed 9 years ago by Mike Wilcox

frietsch, the 1.3.2 is deprecated or at least "use at your own risk". See the docs for how to port newer code to an older base:http://docs.dojocampus.org/dojox/form/FileUploader

Note: See TracTickets for help on using tickets.