Opened 9 years ago

Closed 9 years ago

#11331 closed enhancement (fixed)

[patch] [cla] dijit.Calendar - change _setValueAttr to recognize priorityChange like most other widgets

Reported by: ben hockey Owned by: ben hockey
Priority: high Milestone: 1.6
Component: Dijit Version: 1.5.0b2
Keywords: Cc:
Blocked By: Blocking:

Description

when setting the value, most widgets recognize the priorityChange parameter as a way to prevent onChange from firing. dijit.Calendar doesn't recognize this parameter and it would be nice to have support for it.

Attachments (1)

11331.diff (837 bytes) - added by ben hockey 9 years ago.

Download all attachments as: .zip

Change History (4)

Changed 9 years ago by ben hockey

Attachment: 11331.diff added

comment:1 Changed 9 years ago by ben hockey

Milestone: tbd1.5.1
Owner: set to ben hockey
Summary: dijit.Calendar - change _setValueAttr to recognize priorityChange like most other widgets[patch] [cla] dijit.Calendar - change _setValueAttr to recognize priorityChange like most other widgets

added a patch that should work. will test and apply after 1.5 is released

comment:2 Changed 9 years ago by bill

Milestone: 1.5.11.6

This isn't critical enough to go into a patch release; I don't mind it going into 1.5 but will mark for 1.6 for now since you said that you still need to test it.

comment:3 Changed 9 years ago by bill

Resolution: fixed
Status: newclosed

(In [22665]) Calendar: separate focus and selection handling, so that (like ColorPalette and Tree), arrow keys navigate and ENTER/SPACE selects the date (fixes #10001 !strict). This allows navigation across disabled dates (refs #6430, fixes #11484), and completes keyboard support for DateTextBox, although it still needs screen reader work (refs #9918).

Also seems to have fixed the ctrl-page-up/down problem on FF/mac (fixes #11483).

Also merged in Calendar.set("value", ..., priorityChange) support from neonstalwart (fixes #11331), thanks!

Note: See TracTickets for help on using tickets.