[regression] dojox.widget.PlaceholderMenuItem.getPlaceHolders() calls JS forEach

[awall]

This breaks in IE8. This call to forEach should use a dojo.forEach.

getPlaceholders: function(/*String?*/ label){

summary: returns an array of placeholders with the given label. There can be multiples. label: Label to search for - if not specified, then all placeholders are returned returns: An array of placeholders that match the given label var r = [];

var children = this.getChildren(); debugger; children.forEach(function(child){

if(child._isPlaceholder && (!label

child.label == label)){

r.push(child);

}else if(child._started && child.popup && child.popup.getPlaceholders){

r = r.concat(child.popup.getPlaceholders(label));

}else if(!child._started && child.dropDownContainer){

var node = dojo.query("[widgetId]", child.dropDownContainer)[0]; var menu = dijit.byNode(node); if(menu.getPlaceholders){

r = r.concat(menu.getPlaceholders(label));

}

}

}, this); return r; dojox.widget.PlaceholderMenuItem?[]

}

[dante]

(In [22512]) fixes #11319 - change from getChildren returning a nodelist to an array

[bill]

Perhaps should be backported to 1.5 given the regression. See also #11532.

[dante]

(In [22710]) fixes #11319 in 1.5.x branch, backported from [22512]