Opened 9 years ago

Closed 9 years ago

#11319 closed defect (fixed)

[regression] dojox.widget.PlaceholderMenuItem.getPlaceHolders() calls JS forEach

Reported by: awall Owned by: dante
Priority: high Milestone: 1.5.1
Component: DojoX Widgets Version: 1.5.0rc1
Keywords: Cc:
Blocked By: Blocking:

Description

This breaks in IE8. This call to forEach should use a dojo.forEach.

getPlaceholders: function(/*String?*/ label){

summary: returns an array of placeholders with the given label. There can be multiples. label: Label to search for - if not specified, then all placeholders are returned returns: An array of placeholders that match the given label var r = [];

var children = this.getChildren(); debugger; children.forEach(function(child){

if(child._isPlaceholder && (!label
child.label == label)){

r.push(child);

}else if(child._started && child.popup && child.popup.getPlaceholders){

r = r.concat(child.popup.getPlaceholders(label));

}else if(!child._started && child.dropDownContainer){

var node = dojo.query("[widgetId]", child.dropDownContainer)[0]; var menu = dijit.byNode(node); if(menu.getPlaceholders){

r = r.concat(menu.getPlaceholders(label));

}

}

}, this); return r; dojox.widget.PlaceholderMenuItem?[]

}

Change History (5)

comment:1 Changed 9 years ago by dante

Milestone: tbd1.6

comment:2 Changed 9 years ago by dante

Resolution: fixed
Status: newclosed

(In [22512]) fixes #11319 - change from getChildren returning a nodelist to an array

comment:3 Changed 9 years ago by bill

Summary: dojox.widget.PlaceholderMenuItem.getPlaceHolders() calls JS forEach[regression] dojox.widget.PlaceholderMenuItem.getPlaceHolders() calls JS forEach

Perhaps should be backported to 1.5 given the regression. See also #11532.

comment:4 Changed 9 years ago by dante

Milestone: 1.61.5.1
Resolution: fixed
Status: closedreopened

comment:5 Changed 9 years ago by dante

Resolution: fixed
Status: reopenedclosed

(In [22710]) fixes #11319 in 1.5.x branch, backported from [22512]

Note: See TracTickets for help on using tickets.