Opened 11 years ago
Closed 10 years ago
#11319 closed defect (fixed)
[regression] dojox.widget.PlaceholderMenuItem.getPlaceHolders() calls JS forEach
Reported by: | awall | Owned by: | dante |
---|---|---|---|
Priority: | high | Milestone: | 1.5.1 |
Component: | DojoX Widgets | Version: | 1.5.0rc1 |
Keywords: | Cc: | ||
Blocked By: | Blocking: |
Description
This breaks in IE8. This call to forEach should use a dojo.forEach.
getPlaceholders: function(/*String?*/ label){
summary: returns an array of placeholders with the given label. There can be multiples. label: Label to search for - if not specified, then all placeholders are returned returns: An array of placeholders that match the given label var r = [];
var children = this.getChildren(); debugger; children.forEach(function(child){
if(child._isPlaceholder && (!label child.label == label)){ r.push(child);
}else if(child._started && child.popup && child.popup.getPlaceholders){
r = r.concat(child.popup.getPlaceholders(label));
}else if(!child._started && child.dropDownContainer){
var node = dojo.query("[widgetId]", child.dropDownContainer)[0]; var menu = dijit.byNode(node); if(menu.getPlaceholders){
r = r.concat(menu.getPlaceholders(label));
}
}
}, this); return r; dojox.widget.PlaceholderMenuItem?[]
}
Change History (5)
comment:1 Changed 11 years ago by
Milestone: | tbd → 1.6 |
---|
comment:2 Changed 11 years ago by
Resolution: | → fixed |
---|---|
Status: | new → closed |
comment:3 Changed 10 years ago by
Summary: | dojox.widget.PlaceholderMenuItem.getPlaceHolders() calls JS forEach → [regression] dojox.widget.PlaceholderMenuItem.getPlaceHolders() calls JS forEach |
---|
Perhaps should be backported to 1.5 given the regression. See also #11532.
comment:4 Changed 10 years ago by
Milestone: | 1.6 → 1.5.1 |
---|---|
Resolution: | fixed |
Status: | closed → reopened |
comment:5 Changed 10 years ago by
Resolution: | → fixed |
---|---|
Status: | reopened → closed |
(In [22512]) fixes #11319 - change from getChildren returning a nodelist to an array