Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#11309 closed defect (fixed)

<input> tag not closed in form/templates/*.html

Reported by: cjh Owned by: Douglas Hays
Priority: high Milestone: 1.5
Component: Dijit Version: 1.5.0b2
Keywords: Cc: jochen.hansmeyer@…
Blocked By: Blocking:

Description (last modified by bill)

<input ${!nameAttrSetting} type="${type}" value="${value}" style="display:none !important;" dojoAttachPoint="valueNode"></span

should be:

<input ${!nameAttrSetting} type="${type}" value="${value}" style="display:none !important;" dojoAttachPoint="valueNode">'''</input>'''</span

Attachments (1)

11309.patch (7.0 KB) - added by Douglas Hays 9 years ago.
patch against 1.5 trunk - needs verification

Download all attachments as: .zip

Change History (7)

comment:1 Changed 9 years ago by Adam Peller

Owner: set to Douglas Hays

I think this is deliberate because of some browser quirk. Doug can confirm.

comment:2 Changed 9 years ago by Douglas Hays

This is tricky. Self-closing the INPUT tags is invalid HTML4 markup, but required for XHTML, and optional for HTML5, but we have the same templates for all.

Changed 9 years ago by Douglas Hays

Attachment: 11309.patch added

patch against 1.5 trunk - needs verification

comment:3 Changed 9 years ago by Douglas Hays

Please verify that the attached patch fixes your problems. I cannot add </input> since that causes IE to generate a separate </INPUT> node in HTML4 mode, so I used self-closing tags instead <INPUT/>.

comment:4 in reply to:  3 Changed 9 years ago by cjh

Thanks, the <input/> fixes my problem !

comment:5 Changed 9 years ago by Douglas Hays

Resolution: fixed
Status: newclosed

(In [22335]) Fixes #11309. Ensure INPUT tags in templates are self-closed so that they work with XHTML pages.

comment:6 Changed 9 years ago by bill

Description: modified (diff)

BTW, this is the same fire drill we did with <img> tags in the templates, which we also ended up changing to <img/>

Note: See TracTickets for help on using tickets.