Opened 12 years ago
Closed 12 years ago
#11291 closed defect (fixed)
vmlElems declared as a global
Reported by: | ben hockey | Owned by: | Eugene Lazutkin |
---|---|---|---|
Priority: | high | Milestone: | 1.5 |
Component: | Core | Version: | 1.5.0b2 |
Keywords: | Cc: | alex | |
Blocked By: | Blocking: |
Description
in hostenv_browser.js, vmlElems
is being declared as a global. is this intentional or could we wrap that block in a closure:
try{ (function(){ document.namespaces.add("v", "urn:schemas-microsoft-com:vml"); var vmlElems = ["*", "group", "roundrect", "oval", "shape", "rect", "imagedata", "path", "textpath", "text"], i = 0, l = 1, s = document.createStyleSheet(); if(dojo.isIE >= 8){ i = 1; l = vmlElems.length; } for(; i < l; ++i){ s.addRule("v\\:" + vmlElems[i], "behavior:url(#default#VML); display:inline-block"); } })(); }catch(e){}
Change History (4)
comment:1 Changed 12 years ago by
Milestone: | tbd → 1.5 |
---|---|
Owner: | changed from anonymous to James Burke |
comment:2 Changed 12 years ago by
Type: | enhancement → defect |
---|
comment:3 Changed 12 years ago by
Owner: | changed from James Burke to Eugene Lazutkin |
---|---|
Status: | new → assigned |
comment:4 Changed 12 years ago by
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
Note: See
TracTickets for help on using
tickets.
Robot missed: (In [22430]) bugfix: VML initialization was wrapped in a closure, thx neonstalwart! !strict, fixes #11291.