Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#11283 closed enhancement (fixed)

EnhancedImageLinkDialog plugin for Editor

Reported by: Gu Yi, He Owned by:
Priority: high Milestone: 1.6
Component: Editor Version: 1.5.0rc1
Keywords: ibm editor insert local image Cc: heguyi@…, drschwar@…
Blocked By: Blocking:

Description (last modified by Adam Peller)

This ticket will contain the forthcoming new plugin for Editor targeting 1.6. This plugin enhances the classic dijit._editor.plugins.ImgLinkDialog? so that the user can

  1. Insert an online image
  2. Insert a local image on his computer into the document with one click
  3. Edit the image when it is selected

Attachments (3)

EnhancedImageLinkDialog.patch​ (17.0 KB) - added by Adam Peller 9 years ago.
patch from heguyi (IBM, CCLA)
sample.jpg​ (858 bytes) - added by Adam Peller 9 years ago.
dojox/editor/tests/sample.jpg
LocalImagePlugin.patch​ (16.1 KB) - added by Adam Peller 9 years ago.
updated patch from Eldon (IBM, CCLA) Rename plugin + code reductions

Download all attachments as: .zip

Change History (13)

Changed 9 years ago by Adam Peller

Attachment: EnhancedImageLinkDialog.patch​ added

patch from heguyi (IBM, CCLA)

Changed 9 years ago by Adam Peller

Attachment: sample.jpg​ added

dojox/editor/tests/sample.jpg

comment:1 Changed 9 years ago by Adam Peller

Description: modified (diff)

comment:2 Changed 9 years ago by Adam Peller

I suggest dropping 'Enhanced' from the name and instead modifying the existing plugin, with enhancements made in separate plugins extending from the base plugin. Online and local should be separate or mixed functions, if possible, loosely coupled to avoid dependencies on dojox.form for online use.

Changed 9 years ago by Adam Peller

Attachment: LocalImagePlugin.patch​ added

updated patch from Eldon (IBM, CCLA) Rename plugin + code reductions

comment:3 Changed 9 years ago by Jared Jurkiewicz

Resolution: → fixed
Status: new → closed

(In [22854]) Adding in CCLA LocalImage? plugin. fixes #11283

comment:4 Changed 9 years ago by Jared Jurkiewicz

(In [22855]) Removing accidental checkin. refs #11283

comment:5 Changed 9 years ago by Jared Jurkiewicz

(In [22856]) Fixing name. refs #11283

comment:6 Changed 9 years ago by Jared Jurkiewicz

(In [22857]) Removing accidental checkin. refs #11283

comment:7 Changed 9 years ago by Gu Yi, He

Resolution: fixed
Status: closed → reopened

Hi Jared,

Just found that the following two files are missing from the patch:

  1. dojox/editor/plugins/resources/css/LocalImage.css
  2. dojox/editor/plugins/tests/editorLocalImage.html

Would you please have a look? Thanks.

comment:8 Changed 9 years ago by Gu Yi, He

I means the two files do not exist in the trunk but the patch file contains the two.

comment:9 Changed 9 years ago by Jared Jurkiewicz

Resolution: → fixed
Status: reopened → closed

(In [23030]) Checking in missing files. fixes #11283

comment:10 Changed 9 years ago by Jared Jurkiewicz

(In [23031]) Checking in missing files. fixes #11283

Note: See TracTickets for help on using tickets.