[regression] Button: Enter key won't submit form with dijit.form.Button as the submit button in Chrome

[Mark Wubben]

According to <​http://code.google.com/p/chromium/issues/detail?id=45549> Chrome won't let the enter key submit the form if the submit button has display:none.

Sadly this is exactly what happens with dijit.form.Button. Using visibility:hidden !important;position:absolute !important;left:-10000px !important; fixed it for me, but I'm not sure how this affects other browsers / accessibility.

[bill]

Good catch. CSS like left: -10000px tends to break RTL mode but top: -10000px is OK.

[bill]

(In [22387]) Make hidden <input> tag visibility:hidden rather than display:none, so that on webkit, user can still submit forms by pressing ENTER while focused on an <input>. Refs #11003, fixes #11275.

[ben hockey]

this change has added some overflow to firefox where there wasn't previously. i'll attach a test case that you can view at r22386 without overflow and in r22387 you'll see the horizontal scroll bar in the right region.

[ben hockey]

Replying to neonstalwart:

this change has added some overflow to firefox where there wasn't previously.

i confirmed this overflow for ie 8, safari 5 and chrome 6(dev) as well. i know chrome 6 is not currently supported but i'm fairly sure that the problem would be in whichever version of chrome we do support.

[bill]

(In [22394]) second try to fix problems with hidden <input> tag, so that there's no overflow, fixes #11275