Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#11275 closed defect (fixed)

[regression] Button: Enter key won't submit form with dijit.form.Button as the submit button in Chrome

Reported by: Mark Wubben Owned by: bill
Priority: high Milestone: 1.5
Component: Dijit - Form Version: 1.5.0b2
Keywords: Cc:
Blocked By: Blocking:

Description

According to <http://code.google.com/p/chromium/issues/detail?id=45549> Chrome won't let the enter key submit the form if the submit button has display:none.

Sadly this is exactly what happens with dijit.form.Button. Using visibility:hidden !important;position:absolute !important;left:-10000px !important; fixed it for me, but I'm not sure how this affects other browsers / accessibility.

Attachments (1)

r22387.html (1.0 KB) - added by ben hockey 9 years ago.

Download all attachments as: .zip

Change History (8)

comment:1 Changed 9 years ago by Mark Wubben

Owner: set to bill

comment:2 Changed 9 years ago by bill

Milestone: tbd1.5
Status: newassigned
Summary: Enter key won't submit form with dijit.form.Button as the submit button in Chrome[regression] Button: Enter key won't submit form with dijit.form.Button as the submit button in Chrome

Good catch. CSS like left: -10000px tends to break RTL mode but top: -10000px is OK.

comment:3 Changed 9 years ago by bill

Resolution: fixed
Status: assignedclosed

(In [22387]) Make hidden <input> tag visibility:hidden rather than display:none, so that on webkit, user can still submit forms by pressing ENTER while focused on an <input>. Refs #11003, fixes #11275.

comment:4 Changed 9 years ago by ben hockey

Resolution: fixed
Status: closedreopened

this change has added some overflow to firefox where there wasn't previously. i'll attach a test case that you can view at r22386 without overflow and in r22387 you'll see the horizontal scroll bar in the right region.

Changed 9 years ago by ben hockey

Attachment: r22387.html added

comment:5 in reply to:  4 Changed 9 years ago by ben hockey

Replying to neonstalwart:

this change has added some overflow to firefox where there wasn't previously.

i confirmed this overflow for ie 8, safari 5 and chrome 6(dev) as well. i know chrome 6 is not currently supported but i'm fairly sure that the problem would be in whichever version of chrome we do support.

comment:6 Changed 9 years ago by bill

Resolution: fixed
Status: reopenedclosed

(In [22394]) second try to fix problems with hidden <input> tag, so that there's no overflow, fixes #11275

comment:7 Changed 9 years ago by bill

Component: DijitDijit - Form
Note: See TracTickets for help on using tickets.