[regression] TooltipDialog: doesn't get focus on mouse click of DropDownButton

[David Schwartz]

The behavior of the keyboard focus currently varies with the technique used to select the toolbar item. Consider the editor tab on ​http://archive.dojotoolkit.org/nightly/dojotoolkit/dijit/themes/themeTester.html?theme=claro. Placing the focus in the toolbar, cursoring over to the Create link item and then using SPACE to select results in the associated tooltipdialog being displayed with the focus in the first field. However, simply clicking on the toolbar item results in the tooltipdialog being displayed but the toolbar item retains the keyboard focus while the first field is in error (the field being in error from the start is yet a different problem). The attached gif illustrates the difference in behavior.

REGARDLESS of the selection technique, the resulting behavior should be the same. The focus should be placed in the appropriate (note, not always the first) field in the dialog; it should not be in the toolbar.

I'm assuming this is a toolbar issue.

[David Schwartz]

video of the difference

[bill]

Agreed. It's an issue with any DropDownButton, regardless of whether it's in a toolbar or not.

[bill]

(In [22672]) Fix TooltipDialog so it gets focus when opened from a mouse click (on a DropDownButton) in addition to a keyboard "click", fixes #11265 !strict.

[bill]

As #11616 pointed out, this worked in 1.4 and broke in 1.5 (and then I fixed it in [22672] above). I guess I should backport the fix to 1.5.

[bill]

(In [22749]) Backport [22672] (focus TooltipDialog on DropDownButton mouse click) to 1.5/ branch, since it's a 1.5/ regression. Refs #11265 !strict.