Opened 9 years ago

Closed 9 years ago

#11261 closed defect (fixed)

dojox.form.manager._Mixin doesn't set radio button values properly

Reported by: ben hockey Owned by: Eugene Lazutkin
Priority: high Milestone: 1.5
Component: DojoX Form Version: 1.5.0b2
Keywords: Cc:
Blocked By: Blocking:

Description

using the test_Manager1.html test page try the following in the firebug console:

dijit.byId("form").formWidgetValue('w02', 'w02-1')

you'll see that the w02-2 radio button is unchecked but w02-1 does not get checked.

i also checked this in dojo 1.4.3 and this same problem exists in that version.

Attachments (2)

formAction.html (998 bytes) - added by ben hockey 9 years ago.
formAction.html from dijit.form.Form unit tests
test_Manager2.html (8.2 KB) - added by ben hockey 9 years ago.
adaptation of dijit.form.Form unit test to help test some of dojox.form.Manager

Download all attachments as: .zip

Change History (7)

Changed 9 years ago by ben hockey

Attachment: formAction.html added

formAction.html from dijit.form.Form unit tests

Changed 9 years ago by ben hockey

Attachment: test_Manager2.html added

adaptation of dijit.form.Form unit test to help test some of dojox.form.Manager

comment:1 Changed 9 years ago by ben hockey

i added a couple of files that might help with testing/identifying this problem. these are just an adaptation of the unit tests for dijit.form.Form. using these, i also found that checkboxes are also not working as expected.

comment:2 Changed 9 years ago by Eugene Lazutkin

Owner: changed from dante to Eugene Lazutkin
Status: newassigned

comment:3 Changed 9 years ago by Eugene Lazutkin

Milestone: tbd1.5
Status: assignednew

comment:4 Changed 9 years ago by Eugene Lazutkin

Status: newassigned

It looks like dijit.form widgets are far from stable, and not exactly regular. I need to special-case both dijit.form.CheckBox and dijit.form.RadioButton now. And replace attr() with appropriate get() and set() calls. I am not sure how well it works with priorityChange from #11284. And if all form widgets were converted to new get/set schema. If some dojox widgets are still define attr() instead of new API they'll break the form manager.

comment:5 Changed 9 years ago by Eugene Lazutkin

Resolution: fixed
Status: assignedclosed

(In [22385]) form.manager: updated the API from using now depricated attr() to get()/set(), adapted changes to dijit.form.RadioButton and dijit.form.CheckBox, thx neonstalwart!, !strict, fixes #11261.

Note: See TracTickets for help on using tickets.