Opened 11 years ago

Closed 11 years ago

#11218 closed enhancement (fixed)

[patch][cla]very small cleanup of dojo/_base/fx.js

Reported by: ben hockey Owned by: ben hockey
Priority: low Milestone: 1.5
Component: fx Version: 1.5.0b2
Keywords: Cc:
Blocked By: Blocking:

Description

i noticed 2 very minor things in fx.js in base that could be changed.

  • there is a variable called _globalTimerList which is intialised to an empty array but never used.
  • an _endTime property is calculated but is only ever used once and isn't necessary since duration could be used in place of _endTime - _startTime

i've attached a patch with these changes.

Attachments (1)

fx.diff​ (772 bytes) - added by ben hockey 11 years ago.

Download all attachments as: .zip

Change History (4)

Changed 11 years ago by ben hockey

Attachment: fx.diff​ added

comment:1 Changed 11 years ago by James Burke

Milestone: tbd → 1.5

If the unit tests pass, please feel free to apply the patch yourself.

comment:2 Changed 11 years ago by ben hockey

Owner: changed from Bryan Forbes to ben hockey

comment:3 Changed 11 years ago by ben hockey

Resolution: → fixed
Status: new → closed

(In [22252]) removed an unnecessary calculation of _endTime and removed an unused variable _globalTimerList. removed some trailing whitespace. passes unit tests and fixes #11218 !strict

Note: See TracTickets for help on using tickets.