Opened 11 years ago
Closed 11 years ago
#11218 closed enhancement (fixed)
[patch][cla]very small cleanup of dojo/_base/fx.js
Reported by: | ben hockey | Owned by: | ben hockey |
---|---|---|---|
Priority: | low | Milestone: | 1.5 |
Component: | fx | Version: | 1.5.0b2 |
Keywords: | Cc: | ||
Blocked By: | Blocking: |
Description
i noticed 2 very minor things in fx.js in base that could be changed.
- there is a variable called
_globalTimerList
which is intialised to an empty array but never used. - an
_endTime
property is calculated but is only ever used once and isn't necessary sinceduration
could be used in place of_endTime - _startTime
i've attached a patch with these changes.
Attachments (1)
Change History (4)
Changed 11 years ago by
comment:1 Changed 11 years ago by
Milestone: | tbd → 1.5 |
---|
comment:2 Changed 11 years ago by
Owner: | changed from Bryan Forbes to ben hockey |
---|
comment:3 Changed 11 years ago by
Resolution: | → fixed |
---|---|
Status: | new → closed |
Note: See
TracTickets for help on using
tickets.
If the unit tests pass, please feel free to apply the patch yourself.