Opened 12 years ago
Last modified 5 years ago
#11212 assigned defect
[patch]dojox.validate.isUrl doesn't validate certain urls correctly
Reported by: | Wiiboy | Owned by: | dylan |
---|---|---|---|
Priority: | high | Milestone: | 1.14 |
Component: | Dojox | Version: | 1.4.3 |
Keywords: | Cc: | Douglas Hays | |
Blocked By: | Blocking: |
Description
It looks like dojox.validate.isUrl doesn't return true if a url has multiple symbols in a row, even if the url is valid. For example, it returns false on all of the following:
http://www.mysite.com/#bla http://www.mysite.com/?bla=x http://www.mysite.com/bla/?x=y http://www.mysite.com/bla/#x
The key there is the ending slash, followed immediately by either a ? or #.
Attachments (1)
Change History (11)
comment:1 Changed 12 years ago by
Component: | General → Dojox |
---|---|
Owner: | changed from anonymous to Adam Peller |
comment:2 Changed 9 years ago by
Changed 9 years ago by
Attachment: | regexp[1].js added |
---|
dojo 1.8.1 dojox regex patch file with the fix to that issue
comment:3 Changed 9 years ago by
Summary: | dojox.validate.isUrl doesn't validate certain urls correctly → [patch]dojox.validate.isUrl doesn't validate certain urls correctly |
---|
comment:4 Changed 9 years ago by
this dojox regexp patch has not been applied in dojo 1.9.0. Disappointing.
comment:5 Changed 9 years ago by
I agree, it's disappointing. It would help if you submitted the change as a pull request with tests added to tests/validate.js, after filling out a http://dojofoundation.org/about/cla.
comment:6 Changed 9 years ago by
Cc: | Douglas Hays added |
---|
comment:7 Changed 7 years ago by
Milestone: | tbd → 1.11 |
---|---|
Owner: | changed from Adam Peller to dylan |
Status: | new → assigned |
I'll review and land this for 1.11.
comment:8 Changed 7 years ago by
Milestone: | 1.11 → 1.12 |
---|
Ok, after massive triage, ended up with about 80 tickets for 1.11 and 400 or so for 1.12. That's a bit unrealistic, so first I changed all 1.12 to 1.13 (with the plan to move some forward to the new 1.12. Now, I'm moving some of the 1.11 tickets that are less likely to get done this month without help to 1.11. Feel free to help out in January if you want to see this ticket land in 1.11.
comment:9 Changed 6 years ago by
Milestone: | 1.12 → 1.13 |
---|
Ticket planning... move current 1.12 tickets out to 1.13 that likely won't get fixed in 1.12.
comment:10 Changed 5 years ago by
Milestone: | 1.13 → 1.14 |
---|
dojox.regexp.js
Changed the pathRE regex from
To:
The problem was with
Changed it so they will be allowed once.