[patch]dojox.validate.isUrl doesn't validate certain urls correctly

[Wiiboy]

It looks like dojox.validate.isUrl doesn't return true if a url has multiple symbols in a row, even if the url is valid. For example, it returns false on all of the following:

​http://www.mysite.com/#bla ​http://www.mysite.com/?bla=x ​http://www.mysite.com/bla/?x=y ​http://www.mysite.com/bla/#x

The key there is the ending slash, followed immediately by either a ? or #.

[tsemachh]

dojox.regexp.js

Changed the pathRE regex from

"(/(?:[^?#\\s/]+/)*(?:[^?#\\s/]+(?:\\?[^?#\\s/]*)?(?:#[A-Za-z][\\w.:-]*)?)?)?"

To:

"(/(?:)*?([^\\s/])([^?#\\s/]+/)*(?:[^?#\\s/]+(?:\\?[^?#\\s/]*)?(?:#[A-Za-z][\\w.:-]*)?)?)?"

The problem was with

[^?#\\s/]

which indicates that ? and # signs are not allowed after /.

Changed it so they will be allowed once.

[tsemachh]

dojo 1.8.1 dojox regex patch file with the fix to that issue

[mlagree]

this dojox regexp patch has not been applied in dojo 1.9.0. Disappointing.

[bill]

I agree, it's disappointing. It would help if you submitted the change as a pull request with tests added to tests/validate.js, after filling out a ​http://dojofoundation.org/about/cla.

[dylan]

I'll review and land this for 1.11.

[dylan]

Ok, after massive triage, ended up with about 80 tickets for 1.11 and 400 or so for 1.12. That's a bit unrealistic, so first I changed all 1.12 to 1.13 (with the plan to move some forward to the new 1.12. Now, I'm moving some of the 1.11 tickets that are less likely to get done this month without help to 1.11. Feel free to help out in January if you want to see this ticket land in 1.11.

[dylan]

Ticket planning... move current 1.12 tickets out to 1.13 that likely won't get fixed in 1.12.