Opened 10 years ago
Closed 4 years ago
#11199 closed defect (patchwelcome)
_bootstrap/hasConsole test failure
| Reported by: | bill | Owned by: | dylan |
|---|---|---|---|
| Priority: | low | Milestone: | 1.11 |
| Component: | Core | Version: | 1.5.0b2 |
| Keywords: | dohfail | Cc: | |
| Blocked By: | Blocking: |
Description
To reproduce:
- start IE8
- press F12 to get developer console
- select "Console" tab
- load dojo/tests/runTests.html
This gets a failure on:
tests._base._loader.bootstrap: hasConsole
It only happens when the developer console is started, and console is selected, so not sure if there's a real bug or not. Would be nice to avoid the test failure.
Change History (10)
comment:1 Changed 9 years ago by
| Milestone: | tbd → 1.5 |
|---|---|
| Owner: | changed from anonymous to James Burke |
comment:2 Changed 9 years ago by
| Milestone: | 1.5 → 1.6 |
|---|
comment:3 Changed 9 years ago by
| Owner: | changed from James Burke to Mike Wilcox |
|---|
This started with [19922], Mike's change to firebug.js.
Problem starts after the console has been opened, doesn't go way when the console is closed. (It goes away when you restart IE.)
comment:5 Changed 8 years ago by
| Keywords: | dohfail added |
|---|
comment:6 Changed 8 years ago by
| Keywords: | needsreview added |
|---|---|
| Priority: | high → low |
comment:7 Changed 7 years ago by
| Milestone: | 1.8 → 2.0 |
|---|
1.8 has been tagged; moving all outstanding tickets to next major release milestone.
comment:8 Changed 7 years ago by
| Keywords: | needsreview removed |
|---|
Still happening, does that count as review? Not sure what can be done about it.
comment:9 Changed 4 years ago by
| Owner: | changed from Mike Wilcox to dylan |
|---|---|
| Status: | new → assigned |
comment:10 Changed 4 years ago by
| Milestone: | 2.0 → 1.11 |
|---|---|
| Resolution: | → patchwelcome |
| Status: | assigned → closed |
Given that no one has addressed this in 5 years, and we're trying to make our tickets manageable, I'm going to mark this as patchwelcome. If you want to create a pull request via github following the guidelines at https://github.com/dojo/dojo/blob/master/CONTRIBUTING.md , we'll review and land it.
1.5 is released, moving remaining tickets to 1.6