Opened 10 years ago

Closed 9 years ago

#11192 closed defect (fixed)

Soria/nihilo: missing loading animation

Reported by: haysmark Owned by: bill
Priority: high Milestone: 1.5
Component: Dijit - LnF Version: 1.5.0b2
Keywords: Cc:
Blocked By: Blocking:

Description

See:

http://archive.dojotoolkit.org/nightly/checkout/dijit/themes/themeTester.html?theme=nihilo

http://archive.dojotoolkit.org/nightly/checkout/dijit/themes/themeTester.html?theme=soria

Under Popups and Alerts, click "modal dialog with animation". Indeed in Claro and Tundra, you see a little animation to the left of Loading. In the above links however, there is no animation.

Change History (4)

comment:1 Changed 9 years ago by bill

Milestone: tbd1.5
Owner: set to bill

Right, those themes have never had animations, I could add the claro animation, or the tundra one, or just leave them as is. Not sure which is best... I don't think it matters much one way or the other. My initial instinct was to not add an animation as I'm not interested in changing the existing look of soria/nihilo. OTOH, as you mentioned, themeTester.html is confusing.

comment:2 Changed 9 years ago by Adam Peller

Milestone: 1.51.6

comment:3 Changed 9 years ago by bill

Milestone: 1.61.5
Status: newassigned

I'll just change the wording.

comment:4 Changed 9 years ago by bill

Resolution: fixed
Status: assignedclosed

(In [22396]) reword description since not all themes have a loading animation, fixes #11192.

Note: See TracTickets for help on using tickets.