#11188 closed defect (fixed)
dojox.grid throws null pointer exception when calling _delayedCellFocus
Reported by: | kludgeless | Owned by: | Karl Tiedt |
---|---|---|---|
Priority: | high | Milestone: | 1.6.2 |
Component: | DojoX Grid | Version: | 1.5.0b2 |
Keywords: | Cc: | Evan | |
Blocked By: | Blocking: |
Description (last modified by )
There are a number of places in dojox/grid/_FocusManager.js where we check if the column head node is null before performing blurHeader, and only one where we don't which throws exceptions under some circumstances:
_delayedCellFocus: function(){ if(this.isNavHeader()||!this.grid._focused){ return; } var n = this.cell && this.cell.getNode(this.rowIndex); if(n){ try{ if(!this.grid.edit.isEditing()){ dojo.toggleClass(n, this.focusClass, true); this.blurHeader(); dojox.grid.util.fire(n, "focus"); } } catch(e){} } },
We should add a check in the code as follows before calling blurHeader:
Index: _FocusManager.js =================================================================== --- _FocusManager.js (revision 1571) +++ _FocusManager.js (working copy) @@ -104,7 +104,9 @@ try{ if(!this.grid.edit.isEditing()){ dojo.toggleClass(n, this.focusClass, true); - this.blurHeader(); + if (this._colHeadNode){ + this.blurHeader(); + } dojox.grid.util.fire(n, "focus"); } }
Change History (12)
comment:1 Changed 11 years ago by
Component: | General → DojoX Grid |
---|---|
Description: | modified (diff) |
Owner: | changed from anonymous to bryanforbes |
comment:2 Changed 11 years ago by
Owner: | changed from bryanforbes to Bryan Forbes |
---|
comment:3 Changed 10 years ago by
comment:4 Changed 10 years ago by
Owner: | changed from Bryan Forbes to Karl Tiedt |
---|---|
Status: | new → assigned |
claiming to get this fixed... just using my patch since I actually found an additional spot where blurHeaders was being called w/o checking
comment:5 Changed 10 years ago by
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
comment:6 follow-up: 7 Changed 10 years ago by
Cc: | evan added |
---|---|
Milestone: | tbd → 1.7 |
Karl, are the ticket refs backwards on those two checkins?
comment:7 Changed 10 years ago by
Replying to peller:
Karl, are the ticket refs backwards on those two checkins?
Crap, yes they are :/
comment:11 Changed 10 years ago by
Milestone: | 1.7 → 1.6.2 |
---|
comment:12 Changed 10 years ago by
Cc: | Evan added; evan removed |
---|
Note: See
TracTickets for help on using
tickets.
Any reason to prolong committing this? Ran across this bug in 1.6 still (obviously not closed) I came to the same conclusion for fixing it, just looked for dupe bugs before opening a new one and found this....