Changes between Initial Version and Version 1 of Ticket #11164


Ignore:
Timestamp:
Jun 29, 2010, 12:28:51 PM (11 years ago)
Author:
bill
Comment:

This looks worrisome to me... it seems like the current code has provisions (the dojo.style(this.domNode, "height") call) to scroll based on the height of the popup, which is affected by the size of the browser window. That's a different measurement than the pageSize parameter, which controls how many items are fetched from the server per request. In other words, pressing page up/page down may not cause a fetch call to the database, but rather just cause scrolling.

After your change it seems like that code is gone.

The other thing is that in some corner cases the height of each row in the drop down could vary (like when they contain an image, using labelFunc), so it's hard to tell how much to scroll except by going one by one.

This code traces back to [8833].

Mark, comments?

Legend:

Unmodified
Added
Removed
Modified