Opened 9 years ago

Closed 9 years ago

#11147 closed defect (fixed)

ScrollingTabContainer - Programmatically Adding Tabs Presents an Extra Gap Between Butons.

Reported by: David Walsh Owned by: bill
Priority: high Milestone: 1.5
Component: Dijit Version: 1.5.0b2
Keywords: Cc:
Blocked By: Blocking:

Description

When you programmatically add tabs to a ScrollingTabContainer? or TabContainer? with existing tabs, an extra "gap" can be seen between the existing tabs and the first programmatically added tab (example image of the issue is attached).

The solution is to remove the "\n\t\t" directives within the ".nowrapTabStrip" DIV in the "templateString" option. Patched class attached.

Attachments (3)

Problem-Example.png​ (28.8 KB) - added by David Walsh 9 years ago.
Image displaying the issue.
ScrollingTabController.js​ (8.6 KB) - added by David Walsh 9 years ago.
Patched ScrollingTabControler?.js Class.
Ticket_11147_ScrollingTabController.diff​ (812 bytes) - added by David Walsh 9 years ago.
Diff / Patch

Download all attachments as: .zip

Change History (6)

Changed 9 years ago by David Walsh

Attachment: Problem-Example.png​ added

Image displaying the issue.

Changed 9 years ago by David Walsh

Attachment: ScrollingTabController.js​ added

Patched ScrollingTabControler?.js Class.

Changed 9 years ago by David Walsh

Attachment: Ticket_11147_ScrollingTabController.diff​ added

Diff / Patch

comment:1 Changed 9 years ago by David Walsh

Please disregard the "ScrollingTabController?.js" attachment.

comment:2 Changed 9 years ago by bill

Milestone: tbd → 1.5
Owner: set to bill
Status: new → assigned

Ah I see, thanks, I'll remove the whitespace, good catch.

comment:3 Changed 9 years ago by bill

Resolution: → fixed
Status: assigned → closed

(In [22172]) Remove whitespace in template causing first programatically added tab to have a (too-large) gap preceding it. Fixes #11147, thanks David!

Note: See TracTickets for help on using tickets.