Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#11137 closed defect (fixed)

Editor CustomUndo doesn't allow for easy 'on the fly' enablement (needed for some plugins)

Reported by: Jared Jurkiewicz Owned by: Jared Jurkiewicz
Priority: high Milestone: 1.5
Component: Editor Version: 1.5.0b2
Keywords: Cc:
Blocked By: Blocking:

Description

Editor CustomUndo? doesn't allow for easy 'on the fly' enablement (needed for some plugins)

There is a check in postCreate for it, which does a require that really should be done as just part of loading the editor, and then it creates new per instance arrays for each editor.

There's no clean way to do either after the fact, so both of these should just always be done. They do not cost much and come into play on the most popular browser anyway (IE).

Attachments (1)

customUndo.patch (3.8 KB) - added by Jared Jurkiewicz 10 years ago.
Patch for customUndo to throttle undo/redo, as well as avoid selecting the entire editor by inadvertant double-clicks anywhere on the toolbar

Download all attachments as: .zip

Change History (4)

Changed 10 years ago by Jared Jurkiewicz

Attachment: customUndo.patch added

Patch for customUndo to throttle undo/redo, as well as avoid selecting the entire editor by inadvertant double-clicks anywhere on the toolbar

comment:1 Changed 10 years ago by Jared Jurkiewicz

Resolution: fixed
Status: newclosed

(In [22146]) Committing in minor tweaks ot customUndo to make selection restore work better as well as fix accidental entire-editor-node selections via double-click. Also made enabling customUndo via plugins simpler. \!strict fixes #11137

comment:2 Changed 10 years ago by Jared Jurkiewicz

(In [22147]) Committing another minor tweak to customUndo, avoid 'filters' when saving state to make sure selections restore. \!strict fixes #11137

comment:3 Changed 10 years ago by Jared Jurkiewicz

(In [22148]) Don't set the moz user select property! Kills viewsource mode, apparently. Doesn't on WebKit?. \!strict refs #11137

Note: See TracTickets for help on using tickets.