Opened 12 years ago

Closed 12 years ago

#11127 closed defect (fixed)

Editor: tundra/toolbar too tall, claro/font too large

Reported by: bill Owned by: bill
Priority: high Milestone: 1.5
Component: Editor Version: 1.5.0b2
Keywords: Cc:
Blocked By: Blocking:

Description (last modified by bill)

[21233] added a test to test_Editor.html for setting a custom font:

<div dojoType="dijit.Editor"
     style="text-align:left; font-size:30pt" id="fontSizedEditor">

That font-size style setting is also affecting the toolbar, making it too tall on tundra. Claro added a font:medium rule to fix the toolbar height problem but makes the toolbar label font too big.

I'm guessing the style="..." setting was only supposed to affect the editor contents? If that's changed to not affect the toolbar then the tundra height problem will be fixed and the claro font-size: medium clause can be removed, fixing the font problem too.

Arguably setting a font-size shouldn't affect the Toolbar height when it's not displaying labels, but the main issue seems to be where that style="..." tag is applied.

What do you think?

Change History (6)

comment:1 Changed 12 years ago by Jared Jurkiewicz

It shouldn't affect the Editor itself, only the contents, right. So probably the editor should read the value off, then clear it from the styles on the editor div.

comment:2 Changed 12 years ago by Jared Jurkiewicz

(In [22137]) Fixing up mirroring anc claring off certain styles from an editor domNode \!strict refs #11127

comment:3 Changed 12 years ago by Jared Jurkiewicz

Owner: changed from Jared Jurkiewicz to bill

There, made it so it clears off font- and lne- styles from the editor.domNode when it clones them down to the editor content. see if you can clear up the clart style issue?

comment:4 Changed 12 years ago by Jared Jurkiewicz

Milestone: tbd1.5

comment:5 Changed 12 years ago by bill

Description: modified (diff)

comment:6 Changed 12 years ago by bill

Resolution: fixed
Status: newclosed

(In [22140]) Remove claro workaround code for Toolbar height, which was making Toolbar labels too big. Refs #10659, fixes #11127.

Note: See TracTickets for help on using tickets.