Opened 9 years ago

Closed 9 years ago

#11114 closed defect (fixed)

Dialog: leaking iframes

Reported by: dan_trang Owned by: bill
Priority: high Milestone: 1.5
Component: Dijit Version: 1.5.0b2
Keywords: dijit dialog iframe leak Cc:
Blocked By: Blocking:

Description (last modified by bill)

Dijit Dialog Leaking IFrames because underlay keeps creating a new iframe everytime "show" is called and only cleans up the last iframe created when "hide" is called.

To reproduce: Create 3 dialogs.

  1. Open Dialog 1.
  2. From Dialog 1 launch Dialog 2.
  3. From Dialog 2 launch Dialog 3.
  4. Close the dialogs.

Inspect the underlay object in the DOM, you'll see that only the last IFrame was destroyed and the other IFrames were leaked.

Change History (2)

comment:1 Changed 9 years ago by bill

Description: modified (diff)
Milestone: tbd1.5
Owner: set to bill
Status: newassigned
Summary: Dijit Dialog Leaking IFramesDialog: leaking iframes

Good catch, I'll fix.

comment:2 Changed 9 years ago by bill

Resolution: fixed
Status: assignedclosed

(In [22133]) Only call underlay.show() when displaying the first Dialog (in a stack of dialogs. When subsequent dialogs are show the same underlay is reused (by just moving it's z-index). Fixes #11114 !strict.

Note: See TracTickets for help on using tickets.