Opened 9 years ago

Closed 9 years ago

#11111 closed defect (fixed)

[regression] IE60 shows an extra margin for ContentPanes if using the GridContainer's CSS

Reported by: Martin Jakobi Owned by: Shane O'Sullivan
Priority: high Milestone: 1.6
Component: Dojox Version: 1.5.0b2
Keywords: css dijit ContentPane ie60 Cc: jfcunat
Blocked By: Blocking:

Description (last modified by bill)

All ContentPanes get an extra margin in the IE60 if the GridContainer's CSS (dojo/dojox/layout/resources/GridContainer.css) is used.

That CSS contains starting at line 68:

.dj_ie6 .dijitContentPane,
.dj_ie6 .dojoxPortlet, .dj_ie6 .dijitTitlePane{
	margin: 10px;
}

Removing line 68 or not using the css the ContentPanes are rendered as expected beside the GridContainer.

See the testcase with a GridContainer? on the "second page". With removing line 12 in the test file the page is rendered as expected.

Attachments (1)

tcExtraMarginOnIE60.html (5.4 KB) - added by Martin Jakobi 9 years ago.
testcase

Download all attachments as: .zip

Change History (5)

Changed 9 years ago by Martin Jakobi

Attachment: tcExtraMarginOnIE60.html added

testcase

comment:1 Changed 9 years ago by bill

Cc: jfcunat added
Component: DijitDojox
Description: modified (diff)
Milestone: tbd1.5
Owner: set to Shane O'Sullivan
Summary: IE60 shows an extra margin for ContentPanes if using the GridContainer's CSS[regression] IE60 shows an extra margin for ContentPanes if using the GridContainer's CSS

I agree, that CSS is weird, GridContainer?.css shouldn't have rules that affect ContentPane, except maybe if the ContentPane is inside a GridContainer. Still, I don't see why there's a special rule for IE6.

That code was added as part of the new GridContainer, in [21950], for #10680.

comment:2 Changed 9 years ago by Adam Peller

Milestone: 1.51.6

comment:3 Changed 9 years ago by Shane O'Sullivan

(In [22753]) Refs #11111 Changes the IE6 CSS rules to be more specific, so that only ContentPane? and TitlePane? widget that are in Portlets are affected, rather than all widgets on the page

comment:4 Changed 9 years ago by Shane O'Sullivan

Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.