Opened 10 years ago

Closed 9 years ago

Last modified 9 years ago

#11104 closed defect (fixed)

Claro Theme Grid.css .dojoxGridHeader .dojoxGridCell has padding issue.

Reported by: Kitson Kelly Owned by: evan
Priority: high Milestone: 1.5
Component: themes Version: 1.5.0b2
Keywords: Cc: Evan, Julie Santilli
Blocked By: Blocking:

Description

There is a padding issue in the header of claro themed Grids, where the background gradient icon is padded out leaving 3px wide of non gradient and making the header look "ugly". It appears there is a 3px padding that is in there which can be removed by adding 0 padding to .claro .dojoxGridHeader .dojoxGridCell which the attached patch does.

My CCLA has been on file from 28 April with Aimee.

Attachments (2)

claroGrid.css.patch (438 bytes) - added by Kitson Kelly 10 years ago.
Adjusts the header padding for the claro theme
grid issue.tiff (25.4 KB) - added by Kitson Kelly 10 years ago.
Example of a grid header padding problem.

Download all attachments as: .zip

Change History (11)

Changed 10 years ago by Kitson Kelly

Attachment: claroGrid.css.patch added

Adjusts the header padding for the claro theme

comment:1 Changed 10 years ago by bill

Cc: Evan added

Evan, seem OK to you?

comment:2 Changed 10 years ago by Kitson Kelly

I found an issue with my patch, because the rows calculate considering the padding in the header, the row widths become mis-aligned.

Basically I am not sure what the header is supposed to look like in the claro theme, but it currently looks "ugly" and I don't think it is what is intended. The padding gets worse when you have a multi-line header. I get the same problem with FF 3.6 and Chrome 5, which I have attached a screen grab.

Changed 10 years ago by Kitson Kelly

Attachment: grid issue.tiff added

Example of a grid header padding problem.

comment:3 Changed 9 years ago by Adam Peller

Cc: Julie Santilli added

comment:4 Changed 9 years ago by Adam Peller

Owner: changed from nonken to Evan

comment:5 Changed 9 years ago by evan

Not seeing the 3px padding issue in latest trunk, will upload a patch to fix the multiple line issue in Claro.

BTW, wasn't able to see the "grid issue.tiff" snapshot.

comment:6 Changed 9 years ago by Adam Peller

(In [22438]) Patch from Evan: prevent content from getting wrapped in header cell. Refs #11104 !strict

comment:7 Changed 9 years ago by Adam Peller

Resolution: fixed
Status: newclosed

please reopen if you can still demonstrate the 3px padding issue

comment:8 Changed 9 years ago by bill

Owner: changed from Evan to evan

comment:9 Changed 9 years ago by evan

(In [23794]) Partially roll back [22438] - column headers should be wrapped by default, only prohibit wrapping when NestedSorting? is on, refs #11104, !strict

Note: See TracTickets for help on using tickets.