#11104 closed defect (fixed)
Claro Theme Grid.css .dojoxGridHeader .dojoxGridCell has padding issue.
| Reported by: | Kitson Kelly | Owned by: | evan |
|---|---|---|---|
| Priority: | high | Milestone: | 1.5 |
| Component: | themes | Version: | 1.5.0b2 |
| Keywords: | Cc: | Evan, Julie Santilli | |
| Blocked By: | Blocking: |
Description
There is a padding issue in the header of claro themed Grids, where the background gradient icon is padded out leaving 3px wide of non gradient and making the header look "ugly". It appears there is a 3px padding that is in there which can be removed by adding 0 padding to .claro .dojoxGridHeader .dojoxGridCell which the attached patch does.
My CCLA has been on file from 28 April with Aimee.
Attachments (2)
Change History (11)
Changed 12 years ago by
| Attachment: | claroGrid.css.patch added |
|---|
comment:2 Changed 12 years ago by
I found an issue with my patch, because the rows calculate considering the padding in the header, the row widths become mis-aligned.
Basically I am not sure what the header is supposed to look like in the claro theme, but it currently looks "ugly" and I don't think it is what is intended. The padding gets worse when you have a multi-line header. I get the same problem with FF 3.6 and Chrome 5, which I have attached a screen grab.
Changed 12 years ago by
| Attachment: | grid issue.tiff added |
|---|
Example of a grid header padding problem.
comment:3 Changed 12 years ago by
| Cc: | Julie Santilli added |
|---|
comment:4 Changed 12 years ago by
| Owner: | changed from nonken to Evan |
|---|
comment:5 Changed 12 years ago by
Not seeing the 3px padding issue in latest trunk, will upload a patch to fix the multiple line issue in Claro.
BTW, wasn't able to see the "grid issue.tiff" snapshot.
comment:6 Changed 12 years ago by
comment:7 Changed 12 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
please reopen if you can still demonstrate the 3px padding issue
comment:8 Changed 11 years ago by
| Owner: | changed from Evan to evan |
|---|
comment:9 Changed 11 years ago by
(In [23794]) Partially roll back [22438] - column headers should be wrapped by default, only prohibit wrapping when NestedSorting? is on, refs #11104, !strict
Adjusts the header padding for the claro theme