Opened 10 years ago

Closed 9 years ago

#11103 closed defect (fixed)

Claro Theme Tree.css missing .claro .dijitTreeIcon

Reported by: Kitson Kelly Owned by: nonken
Priority: high Milestone: 1.5
Component: themes Version: 1.5.0b2
Keywords: Cc:
Blocked By: Blocking:

Description

It appears that the CSS for the claro theme is missing any sizing for the .dijitTreeIcon so that any node icons don't appear to be rendered. Attached is a patch that adds this in line with the other themes.

My CCLA is on file since 28 April with Aimee.

Attachments (1)

Tree.css.patch (488 bytes) - added by Kitson Kelly 10 years ago.
Adds .claro .dijitTreeIcon

Download all attachments as: .zip

Change History (4)

Changed 10 years ago by Kitson Kelly

Attachment: Tree.css.patch added

Adds .claro .dijitTreeIcon

comment:1 Changed 10 years ago by bill

My thinking is that every icon should define it's own size. Claro defines sizes for the icons it provides (namely, the open and closed folder, and the leaf icon), but if an app defines it's own icons (which could be any size, not just 16x16) then it should explicitly specify a size for them.

Or is there another issue that you are seeing?

comment:2 Changed 10 years ago by Kitson Kelly

Ok... that makes sense, it is just that it differs from every other theme then, which meant that when my code ported all my Tree ICON's disappeared. I would suspect as more people migrate, they will probably run across the same thing. There is a specific class of CSS for it that doesn't have a rule at all then for claro.

I will simply mend my Icon Classes for the tree, but I don't know if there is a wider issue that needs to be addressed for consistency.

comment:3 Changed 9 years ago by bill

Resolution: fixed
Status: newclosed

OK, I added this info to the release notes.

Note: See TracTickets for help on using tickets.