Opened 11 years ago

Closed 11 years ago

#11097 closed enhancement (fixed)

[patch][ccla]Style output from dijit.Editor varies across browsers

Reported by: Jared Jurkiewicz Owned by: Jared Jurkiewicz
Priority: high Milestone: 1.5
Component: Editor Version: 1.5.0b1
Keywords: Cc:
Blocked By: Blocking:

Description

Style output from dijit.Editor varies across browsers

This is most commonly seen where some uses CSS, some <b>, some a mix. It would be great if we could commonize it a bit futher to at least consistently use one or the other on output of HTML markup.

I've got a very experimental prototype that adds filters to try and 'commonize' the output as best it can to either semantic or css (your choice) when you register the plugin.

Attachments (1)

normalizestyle.patch​ (25.0 KB) - added by Jared Jurkiewicz 11 years ago.
Updated patch with some code reductions and fixes.

Download all attachments as: .zip

Change History (12)

comment:1 Changed 11 years ago by Jared Jurkiewicz

Summary: Style output from dijit.Editor varies across browsers → [patch][ccla]Style output from dijit.Editor varies across browsers

Changed 11 years ago by Jared Jurkiewicz

Attachment: normalizestyle.patch​ added

Updated patch with some code reductions and fixes.

comment:2 Changed 11 years ago by Jared Jurkiewicz

This relies on fixes added in ticket: #11137 ​http://trac.dojotoolkit.org/ticket/11137

comment:3 Changed 11 years ago by Jared Jurkiewicz

(In [22149]) Adding in prototype drop of style nomalizer plugin. Still very experimental. refs #11097

comment:4 Changed 11 years ago by Jared Jurkiewicz

(In [22151]) Fixing a mapping bug + a few other things to avoid messing with block node styles. refs #11097

comment:5 Changed 11 years ago by Jared Jurkiewicz

(In [22152]) Reducing the number of functions created by changing the usage of dojo.withGlobal. refs #11097

comment:6 Changed 11 years ago by Jared Jurkiewicz

(In [22161]) Avoid messing with background color if it happens to be a block node. Doesn't work very well to move background color in for block nodes. Also, don't mess with wrapper block nodes like table, ul, ol. refs #11097

comment:7 Changed 11 years ago by Jared Jurkiewicz

(In [22162]) Try to map px and pt to some font size (old style). refs #11097

comment:8 Changed 11 years ago by Jared Jurkiewicz

(In [22167]) Add in over-ride for 'inserthtml' command to do filtering on it, if possible. refs #11097

comment:9 Changed 11 years ago by Jared Jurkiewicz

(In [22173]) Indent fixes (spaces to tabs). No code change. refs #11097

comment:10 Changed 11 years ago by Jared Jurkiewicz

(In [22186]) Add in a testpage that shows just about every plugin enabled/working together. refs #11097

comment:11 Changed 11 years ago by Jared Jurkiewicz

Milestone: tbd → 1.5
Resolution: → fixed
Status: new → closed

Prototype is in 1.5, likely still needs work but closing the basics of this.

Note: See TracTickets for help on using tickets.