Changes between Initial Version and Version 1 of Ticket #11067


Ignore:
Timestamp:
Apr 29, 2010, 11:42:39 PM (9 years ago)
Author:
bill
Comment:

That disabledOK flag and the code quoted above is from [16801]. Yes, it's setting disabled to false when it's already false, in order to re-run the code in _setDisabledAttr(), because the first time _setDisabledAttr() was run it didn't complete successfully because the editor was hidden.

In other words the intent of that code is not to enable a disabled instance when it gets focus.

The _disabledOK flag means "_setDisabledAttr() was called and ran successfully".

Sounds like this isn't a bug.

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #11067

    • Property Status changed from new to closed
    • Property Component changed from Dijit to Editor
    • Property Resolution changed from to invalid
  • Ticket #11067 – Description

    initial v1  
    1 In r21784 the the method _onFocus has:
     1From [16801] the the method _onFocus has:
    22
     3{{{
    34if(!this.disabled){
    45        if(!this._disabledOK){
     
    78        this.inherited(arguments);
    89}
     10}}}
    911
    1012This seems to be setting disabled to false iff it is already false--which seems incorrect. Seems like the intent here is to enable a disabled instance when it gets the focus iff the _disabledOK attribute is false. If so, probably want: