Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#11066 closed defect (fixed)

Table Plugins: Cell color is not consistent behavior across browsers.

Reported by: Jared Jurkiewicz Owned by: Jared Jurkiewicz
Priority: high Milestone: 1.5
Component: Editor Version: 1.5.0b1
Keywords: Cc:
Blocked By: Blocking:

Description

Table Plugins: Cell color is not consistent behavior across browsers.

The way it selects and colors cells in Firefox varies from IE and also FireFox?.

This is due to how the getSelectedCells function works. I found that if you do it the 'ie' way, using id lookup, you cna get all browsers to behave consistently. So, getting rid of the old way for FF/Safari and commonizing. Also reduced code.

Attachments (1)

tableplugs.patch (6.4 KB) - added by Jared Jurkiewicz 10 years ago.
Patch for cell selection and custom undo

Download all attachments as: .zip

Change History (5)

comment:1 Changed 10 years ago by Jared Jurkiewicz

Also going to turn on editor 'custom undo' for all. It works better than native, particularly in cell editing. Other plugins already enable it to work (like NormalizeIndentOutdent?.

Changed 10 years ago by Jared Jurkiewicz

Attachment: tableplugs.patch added

Patch for cell selection and custom undo

comment:2 Changed 10 years ago by Jared Jurkiewicz

Resolution: fixed
Status: newclosed

(In [22014]) Updating table plugins to fix cell color handling and enable custom undo for all (works better). fixes #11066

comment:3 Changed 10 years ago by Jared Jurkiewicz

(In [22015]) Comment fixes. refs #11066

comment:4 Changed 10 years ago by Jared Jurkiewicz

(In [22020]) Slight code reduction. Don't really need to check that range is collapsed when checking to see if cursor was in a cell. refs #11066

Note: See TracTickets for help on using tickets.