Opened 9 years ago

Closed 9 years ago

Last modified 8 years ago

#11055 closed defect (fixed)

[patch] [cla] CheckBox: declares attributeMap twice

Reported by: Kitson Kelly Owned by: bill
Priority: high Milestone: 1.5
Component: Dijit - Form Version: 1.5.0b1
Keywords: Cc:
Blocked By: Blocking:

Description (last modified by bill)

It appears that the attributeMap is being declared twice in dijit.form.CheckBox in 1.5.0b1 and trunk.

On line 29 there is:

attributeMap: dijit.form._FormWidget.prototype.attributeMap,

and on line 57 there is:

attributeMap: dojo.delegate(dijit.form.ToggleButton.prototype.attributeMap, {
	readOnly: "focusNode"
}),

Line 57 looks exactly like prior versions and the comment before line 29 appears to be new.

The attached patch combines the old declaration with the new inherited attributeMap and removes the duplicate declaration.

Attachments (1)

CheckBox.js.patch (1013 bytes) - added by Kitson Kelly 9 years ago.
Patch that corrects attributeMap duplicate declaration

Download all attachments as: .zip

Change History (5)

Changed 9 years ago by Kitson Kelly

Attachment: CheckBox.js.patch added

Patch that corrects attributeMap duplicate declaration

comment:1 Changed 9 years ago by bill

Component: GeneralDijit
Description: modified (diff)
Owner: anonymous deleted
Summary: dijit.form.CheckBox declares attributeMap twice..CheckBox: declares attributeMap twice

Ah you are right, the first one is from [21351], from me, and I messed it up. Your patch is pretty small but it would be better if you filed a CLA, please let us know when you've done that. Thanks!

comment:2 Changed 9 years ago by bill

Milestone: tbd1.5
Owner: set to bill
Status: newassigned
Summary: CheckBox: declares attributeMap twice[patch] [cla] CheckBox: declares attributeMap twice

comment:3 Changed 9 years ago by bill

Resolution: fixed
Status: assignedclosed

(In [22018]) Remove duplicate attributeMap declaration, patch from kitsonk, thanks! Fixes #11055.

comment:4 Changed 8 years ago by bill

Component: DijitDijit - Form
Note: See TracTickets for help on using tickets.