#11043 closed defect (fixed)
[patch][ccla]Slider bugs in RTL mode
Reported by: | bill | Owned by: | Douglas Hays |
---|---|---|---|
Priority: | high | Milestone: | 1.5 |
Component: | Dijit - Form | Version: | 1.4.0 |
Keywords: | Cc: | Adam Peller | |
Blocked By: | Blocking: |
Description (last modified by )
Slider has issues in IE8+RTL mode including cut-off labels and misplaced handle, see the attached screenshot for details. IE6 and 7 render fine.
Attachments (5)
Change History (20)
Changed 12 years ago by
Attachment: | Slider.JPG added |
---|
comment:1 Changed 12 years ago by
Version: | 1.5.0b1 → 1.4.0 |
---|
Forgot to mention, this isn't a new bug. However, it does make slider near-unusable in RTL mode, since the labels aren't visible.
comment:3 Changed 12 years ago by
Description: | modified (diff) |
---|
comment:4 follow-up: 10 Changed 12 years ago by
Cc: | Adam Peller added |
---|
peller, in what version of FF and what OS are you not seeing the thumb image? I see it in FF3.5 and FF3.6 on WinXP. I tested against: http://download.dojotoolkit.org/release-1.5.0b2/dojo-release-1.5.0b2/dijit/tests/form/test_Slider.html?theme=tundra&dir=rtl
Changed 12 years ago by
Attachment: | 11043.patch added |
---|
possible fix changing image handle to position:relative so that % can be used
comment:5 Changed 12 years ago by
Milestone: | tbd → 1.5 |
---|---|
Status: | new → assigned |
Summary: | Slider bugs in RTL mode → [patch][ccla]Slider bugs in RTL mode |
bill, please review the attached patch
comment:6 Changed 12 years ago by
It looks good in IE8 and the CSS is in an improvement (because it doesn't hardcode things -like -6px), but on IE8/IE7 compat mode (for test_Slidr?dir=rtl) I don't see the slider handle at all. On the bright side, the labels seem to be fixed on IE8 and IE8/IE7 compat mode.
comment:7 Changed 12 years ago by
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
Changed 12 years ago by
Attachment: | ieQuirks.png added |
---|
label position problem, IE quirks vertical slider
comment:8 Changed 12 years ago by
Resolution: | fixed |
---|---|
Status: | closed → reopened |
Changed 12 years ago by
Attachment: | 11043.2.patch added |
---|
add position:relative to decoration TD tags
comment:9 follow-up: 11 Changed 12 years ago by
bill, please review the last patch that fixes the IE+quirks+RTL+vertical rendering bug. This was more IE absolute positioning nonsense. I added position:relative to the TD decoration containers similar to how Spinner fixed the arrows rendering problem initially.
comment:10 Changed 12 years ago by
Replying to doughays:
peller, in what version of FF and what OS are you not seeing the thumb image? I see it in FF3.5 and FF3.6 on WinXP. I tested against: http://download.dojotoolkit.org/release-1.5.0b2/dojo-release-1.5.0b2/dijit/tests/form/test_Slider.html?theme=tundra&dir=rtl
He was problem running from a case sensitive file system or a case sensitive web server, there was a case problem that Cougar just fixed in [22119].
comment:11 Changed 12 years ago by
Replying to doughays:
bill, please review the last patch that fixes the IE+quirks+RTL+vertical rendering bug. This was more IE absolute positioning nonsense. I added position:relative to the TD decoration containers similar to how Spinner fixed the arrows rendering problem initially.
Great, looking a lot better. The only thing I noticed is that IE6 looks "warped" when numbers are on both sides. Not sure if that's fixable or not:
comment:12 Changed 12 years ago by
Resolution: | → fixed |
---|---|
Status: | reopened → closed |
comment:13 Changed 12 years ago by
comment:14 Changed 12 years ago by
comment:15 Changed 11 years ago by
Component: | Dijit → Dijit - Form |
---|
screenshot w/problems in red squares