[patch][ccla]Slider bugs in RTL mode

[bill]

Slider has issues in IE8+RTL mode including cut-off labels and misplaced handle, see the attached screenshot for details. IE6 and 7 render fine.

[bill]

screenshot w/problems in red squares

[bill]

Forgot to mention, this isn't a new bug. However, it does make slider near-unusable in RTL mode, since the labels aren't visible.

[Adam Peller]

in FF, the thumb is invisible in RTL mode

[Douglas Hays]

peller, in what version of FF and what OS are you not seeing the thumb image? I see it in FF3.5 and FF3.6 on WinXP. I tested against: ​http://download.dojotoolkit.org/release-1.5.0b2/dojo-release-1.5.0b2/dijit/tests/form/test_Slider.html?theme=tundra&dir=rtl

[Douglas Hays]

possible fix changing image handle to position:relative so that % can be used

[Douglas Hays]

bill, please review the attached patch

[bill]

It looks good in IE8 and the CSS is in an improvement (because it doesn't hardcode things -like -6px), but on IE8/IE7 compat mode (for test_Slidr?dir=rtl) I don't see the slider handle at all. On the bright side, the labels seem to be fixed on IE8 and IE8/IE7 compat mode.

[Douglas Hays]

(In [22108]) Fixes #11043. Changed image handle from position:absolute to relative so that left/right % values can be used instead of handcoded px values. Changed rule-labels to be a block div instead of inline span so that the labels are fully rendered in IE.

[bill]

label position problem, IE quirks vertical slider

[bill]

Cool, looking a lot better. I see one remaining problem on IE quirks RTL mode (all versions of IE), hopefully you can fix that one too. Here's a screenshot from themeTesterQuirk.html?theme=claro&dir=rtl:

[Douglas Hays]

add position:relative to decoration TD tags

[Douglas Hays]

bill, please review the last patch that fixes the IE+quirks+RTL+vertical rendering bug. This was more IE absolute positioning nonsense. I added position:relative to the TD decoration containers similar to how Spinner fixed the arrows rendering problem initially.

[bill]

Replying to doughays:

peller, in what version of FF and what OS are you not seeing the thumb image? I see it in FF3.5 and FF3.6 on WinXP. I tested against: ​http://download.dojotoolkit.org/release-1.5.0b2/dojo-release-1.5.0b2/dijit/tests/form/test_Slider.html?theme=tundra&dir=rtl

He was problem running from a case sensitive file system or a case sensitive web server, there was a case problem that Cougar just fixed in [22119].

[bill]

IE6 slider warped around 0 and 100

[bill]

Replying to doughays:

bill, please review the last patch that fixes the IE+quirks+RTL+vertical rendering bug. This was more IE absolute positioning nonsense. I added position:relative to the TD decoration containers similar to how Spinner fixed the arrows rendering problem initially.

Great, looking a lot better. The only thing I noticed is that IE6 looks "warped" when numbers are on both sides. Not sure if that's fixable or not:

[Douglas Hays]

(In [22121]) Fixes #11043. Add position:relative to TD tags within Slider to keep IE fromm misrendering absolute positioned elements.

[Douglas Hays]

(In [22122]) References #11043. position:relative should only be applied to vertical sliders.

[Douglas Hays]

(In [23099]) Fixes #11917. Refs #11043. Constrain vertical slider position:relative on TD to just the middle row and fixup robot tests.