Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#11017 closed defect (fixed)

Multiple fixes to dojox.widget.ColorPicker

Reported by: Jared Jurkiewicz Owned by: Jared Jurkiewicz
Priority: high Milestone: 1.5
Component: Dojox Version: 1.4.0
Keywords: Cc:
Blocked By: Blocking:

Description

Multiple fixes to dojox.widget.ColorPicker?

1.) Removed much of the absolute positioning. Required rewriting the template. Had to use tables. Kinda sucky, but lays out more consistently now.

2.) Added arrow key control of saturation and hue pickers.

3.) Fixed ally some on IE by making sure the input field changes call color update.

Attachments (1)

ColorPicker.patch (16.1 KB) - added by Jared Jurkiewicz 10 years ago.
Patch for all the noted issues resolved.

Download all attachments as: .zip

Change History (5)

comment:1 Changed 10 years ago by Jared Jurkiewicz

Also fixed the way the node initially 'jumps' when you click on it to move. The problem comes from dojo/dnd/Mover.js in onFirstMove, where it uses node.style. Since the class was what was setting the node to absolute, t/l of 0, it didn't show up in Mover as absolute and it went down the wrong codepath. Cheap fix/workaround was just to move those styles into the template. Sucky, but the jump was extremely annoying.

Changed 10 years ago by Jared Jurkiewicz

Attachment: ColorPicker.patch added

Patch for all the noted issues resolved.

comment:2 Changed 10 years ago by Jared Jurkiewicz

Resolution: fixed
Status: newclosed

(In [21910]) Many fixes to ColorPicker? in dojox, from dnd move, to keyboard control of selector, to removing lots of absolute positioning in the template. fixes #11017

comment:3 Changed 10 years ago by Jared Jurkiewicz

(In [21911]) Use the builtin auto-cleanup array. refs #11017

comment:4 Changed 10 years ago by Jared Jurkiewicz

(In [21912]) Click to select color also focuses the mover. refs #11017

Note: See TracTickets for help on using tickets.