Opened 9 years ago

Closed 8 years ago

#11008 closed defect (fixed)

dijitInlineTable related CSS fixes

Reported by: bill Owned by: bill
Priority: high Milestone: 1.7
Component: Dijit Version: 1.4.0
Keywords: Cc:
Blocked By: Blocking:

Description

There are a number of issues related to dijitInlineTable (the class to inline tables) that need to be fixed. They include:

  • the Select widget uses dijitInline when it should use dijitInlineTable (since it's a <table>)
  • conversely, ValidationTextBox uses dijitInlineTable when it should use dijitInilne
  • The dijitInlineTable definition itself is also strange since it defaults to inline-block (on browsers that support that display setting) rather than inline-table. This is causing width:100% on a Select widget to not expand the Select widget to the width of it's container.

Change History (6)

comment:1 Changed 9 years ago by bill

(In [21893]) Proper fix for problem where Select's bottom and right borders weren't visible on IE8. Since there are borders on both the <td> (white border) and the <table> (blue border), need to set border-collapse: separate. Refs #10527, #11008.

comment:2 Changed 9 years ago by Jonathan Bond-Caron

I noticed this too, it would be great for consistency

Inline widgets: All <table> nodes are .dijitInlineTable All other nodes are .dijitInline

This might fix alignment issues:

.dijitInline, .dijitInlineTable {

vertical-align: text-bottom;

}

Could cleanup a lot of css hacks, widgets that need "vertical-align: middle;" can use it...

comment:3 Changed 9 years ago by Adam Peller

Milestone: 1.51.6

comment:4 Changed 9 years ago by bill

See also #11456, can probably be closed together.

comment:5 Changed 8 years ago by bill

Milestone: 1.61.7

comment:6 Changed 8 years ago by bill

Resolution: fixed
Status: newclosed

(In [25422]) Combine dijitInline with dijitInlineTable. Seems to be working although time will tell. Fixes #11008.

Note: See TracTickets for help on using tickets.