Opened 11 years ago

Closed 10 years ago

#11002 closed task (fixed)

[patch][cla]dijit.layout.StackController onAddChild has attach dom node twice.

Reported by: youngho Owned by: bill
Priority: high Milestone: 1.5
Component: Dijit Version: 1.4.0
Keywords: StackController Cc:
Blocked By: Blocking:

Description

onAddChild method has

this.domNode.appendChild(refNode); and

this.addChild(button, insertIndex);

looks like

this.domNode.appendChild(refNode); doesn't need.

Attachments (1)

StackController.patch​ (476 bytes) - added by youngho 11 years ago.

Download all attachments as: .zip

Change History (3)

Changed 11 years ago by youngho

Attachment: StackController.patch​ added

comment:1 Changed 10 years ago by bill

Milestone: tbd → 1.5
Owner: set to bill
Status: new → assigned
Type: defect → task

Makes sense, actually that whole refNode seems unnecessary, I'll remove it.

comment:2 Changed 10 years ago by bill

Resolution: → fixed
Status: assigned → closed

(In [22428]) Removing some unnecessary code, thanks youngho, fixes #11002 !strict.

Note: See TracTickets for help on using tickets.