Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#10996 closed defect (fixed)

Remove 'global' table handler from TablePlugins

Reported by: Jared Jurkiewicz Owned by: Jared Jurkiewicz
Priority: high Milestone: 1.5
Component: Editor Version: 1.4.0
Keywords: Cc:
Blocked By: Blocking:

Description

Remove 'global' table handler from TablePlugins?

The global causes serious issues, namely that you can only have one editor on the page which uses table plugins. It also had memory leaks due to connects not getting cleaned up, as well as subscribes dangling.

Moving the handler to be 'per editor' so that proper cleanup can happen and that it doesn't collide.

Attachments (2)

globalRemoval.patch (6.3 KB) - added by Jared Jurkiewicz 10 years ago.
tablePlugin.patch (24.7 KB) - added by youngho 10 years ago.

Download all attachments as: .zip

Change History (5)

comment:1 Changed 10 years ago by Jared Jurkiewicz

Milestone: tbd1.5

Changed 10 years ago by Jared Jurkiewicz

Attachment: globalRemoval.patch added

comment:2 Changed 10 years ago by Jared Jurkiewicz

Resolution: fixed
Status: newclosed

(In [21838]) Quick-fixing (it's not the best way, probably), the table plugin global. fixes #10996

comment:3 Changed 10 years ago by youngho

Here is another approach using Buttons Palette.

Editor toolbar has one dropDown button for Table Plugins only and in the dropDown button, the Botton Pallet cell has each table plugins buttons.

It works well with IE,FF,Chrome,Safari except the colorTableCell ColorPalette? popup behavior. When colorTableCell botton mouseup, so far I don't know how to keep th ColorPalette? popup open. but if you select the color with mousedown state than it works well.

I attach the patch for it.

Changed 10 years ago by youngho

Attachment: tablePlugin.patch added
Note: See TracTickets for help on using tickets.