Opened 9 years ago

Closed 9 years ago

#10982 closed defect (fixed)

_meta.parents not set correctly in dojo.declare

Reported by: Rawld Gill Owned by: Eugene Lazutkin
Priority: high Milestone: 1.5
Component: Core Version: 1.4.2
Keywords: Cc:
Blocked By: Blocking:

Description

parents variable is set before argument juggling, causing _meta.parents to be set incorrectly if dojo.declare is called without a className argument. Patch + test attached.

Attachments (2)

declare-fix.diff​ (669 bytes) - added by Rawld Gill 9 years ago.
patch (tested on FF)
declare-arg-test.js​ (434 bytes) - added by Rawld Gill 9 years ago.
test that demonstrates error and proposed path

Download all attachments as: .zip

Change History (5)

Changed 9 years ago by Rawld Gill

Attachment: declare-fix.diff​ added

patch (tested on FF)

Changed 9 years ago by Rawld Gill

Attachment: declare-arg-test.js​ added

test that demonstrates error and proposed path

comment:1 Changed 9 years ago by Adam Peller

Owner: changed from anonymous to Eugene Lazutkin

comment:2 Changed 9 years ago by Eugene Lazutkin

Milestone: tbd → 1.5
Status: new → assigned

comment:3 Changed 9 years ago by Eugene Lazutkin

Resolution: → fixed
Status: assigned → closed

(In [21824]) Fixing the parents, thx rcgill!, !strict, fixes #10982.

Note: See TracTickets for help on using tickets.