Opened 9 years ago
Last modified 3 years ago
#10973 assigned enhancement
[patch][ccla]VML show text contains '\n' in multiples while SVG don't
| Reported by: | liyang | Owned by: | Jared Jurkiewicz |
|---|---|---|---|
| Priority: | high | Milestone: | 1.15 |
| Component: | DojoX GFX | Version: | 1.4.0 |
| Keywords: | Cc: | ||
| Blocked By: | Blocking: |
Description
Text contains '\n' is shown in multiple lines with VML renderer, but shown in a single line with SVG renderer. The behavior shall be consistent and better to be multi-line.
Attachments (1)
Change History (11)
Changed 9 years ago by
| Attachment: | multi-line-text.patch added |
|---|
comment:1 Changed 9 years ago by
| Summary: | VML show text contains '\n' in multiples while SVG don't → [patch][ccla]VML show text contains '\n' in multiples while SVG don't |
|---|
comment:2 Changed 9 years ago by
| Milestone: | tbd → 1.5 |
|---|---|
| Status: | new → assigned |
Please add test cases for 1, 2, 3, and 5 lines.
comment:3 Changed 9 years ago by
It would be nice to make sure that Silverlight works with multiline text too.
comment:4 Changed 9 years ago by
| Milestone: | 1.5 → 1.6 |
|---|---|
| Type: | defect → enhancement |
comment:5 Changed 8 years ago by
| Milestone: | 1.6 → 1.7 |
|---|
comment:6 Changed 8 years ago by
| Milestone: | 1.7 → 1.8 |
|---|
comment:7 Changed 8 years ago by
Instead of calculating lineHeight, I recommend using em instead:
tspan.setAttribute("dy", (i==0) ? "0em" : "1.2em");
comment:8 Changed 7 years ago by
| Milestone: | 1.8 → 2.0 |
|---|
1.8 is frozen. Move all enhancements to next release. If you need an exemption from the freeze for this ticket, contact me immediately.
comment:9 Changed 3 years ago by
| Milestone: | 2.0 → 1.12 |
|---|---|
| Owner: | changed from Eugene Lazutkin to Jared Jurkiewicz |
Jared, care to create a pull request with this change, if still relevant?
comment:10 Changed 3 years ago by
| Milestone: | 1.13 → 1.15 |
|---|
Ticket planning... move current 1.13 tickets out to 1.15 to make it easier to move tickets into the 1.13 milestone.
Reviewed patch from co-worker, verified it is clean and under CCLA.