Opened 10 years ago

Last modified 3 years ago

#10973 assigned enhancement

[patch][ccla]VML show text contains '\n' in multiples while SVG don't

Reported by: liyang Owned by: Jared Jurkiewicz
Priority: high Milestone: 1.15
Component: DojoX GFX Version: 1.4.0
Keywords: Cc:
Blocked By: Blocking:

Description

Text contains '\n' is shown in multiple lines with VML renderer, but shown in a single line with SVG renderer. The behavior shall be consistent and better to be multi-line.

Attachments (1)

multi-line-text.patch (1.1 KB) - added by Jared Jurkiewicz 10 years ago.
Reviewed patch from co-worker, verified it is clean and under CCLA.

Download all attachments as: .zip

Change History (11)

Changed 10 years ago by Jared Jurkiewicz

Attachment: multi-line-text.patch added

Reviewed patch from co-worker, verified it is clean and under CCLA.

comment:1 Changed 9 years ago by Adam Peller

Summary: VML show text contains '\n' in multiples while SVG don't[patch][ccla]VML show text contains '\n' in multiples while SVG don't

comment:2 Changed 9 years ago by Eugene Lazutkin

Milestone: tbd1.5
Status: newassigned

Please add test cases for 1, 2, 3, and 5 lines.

comment:3 Changed 9 years ago by Eugene Lazutkin

It would be nice to make sure that Silverlight works with multiline text too.

comment:4 Changed 9 years ago by Eugene Lazutkin

Milestone: 1.51.6
Type: defectenhancement

comment:5 Changed 9 years ago by Eugene Lazutkin

Milestone: 1.61.7

comment:6 Changed 8 years ago by Chris Mitchell

Milestone: 1.71.8

comment:7 Changed 8 years ago by stelapad

Instead of calculating lineHeight, I recommend using em instead:

tspan.setAttribute("dy", (i==0) ? "0em" : "1.2em");

comment:8 Changed 7 years ago by Colin Snover

Milestone: 1.82.0

1.8 is frozen. Move all enhancements to next release. If you need an exemption from the freeze for this ticket, contact me immediately.

comment:9 Changed 4 years ago by dylan

Milestone: 2.01.12
Owner: changed from Eugene Lazutkin to Jared Jurkiewicz

Jared, care to create a pull request with this change, if still relevant?

comment:10 Changed 3 years ago by dylan

Milestone: 1.131.15

Ticket planning... move current 1.13 tickets out to 1.15 to make it easier to move tickets into the 1.13 milestone.

Note: See TracTickets for help on using tickets.