Opened 10 years ago

Closed 10 years ago

#10963 closed defect (fixed)

a bug in path.js v21708 prevents getTransformedBoundingBox()

Reported by: liyang Owned by: Eugene Lazutkin
Priority: high Milestone: 1.5
Component: DojoX GFX Version: 1.4.0
Keywords: Cc:
Blocked By: Blocking:

Description

at line 45, it should be "this.tbbox";

at line 55~58, the "t" could be null at this time if the path has zero segments, thus need to be guarded.

Change History (5)

comment:1 Changed 10 years ago by Adam Peller

Resolution: fixed
Status: newclosed

(In [21771]) checked in fixes from liyang. !strict Fixes #10963, Refs #9948

comment:2 Changed 10 years ago by Adam Peller

Thanks. In the future, it's probably better to reopen the old ticket to resolve issues like this.

I put an if around the tbbox assignment. If t is null, should tbbox be assigned to null?

comment:3 Changed 10 years ago by Eugene Lazutkin

Milestone: tbd1.5

comment:4 Changed 10 years ago by liyang

Resolution: fixed
Status: closedreopened

Yes, I think tbbox should be null in case t is null. Reopen this one?

And thanks for the advice, I'll reopen in the future.

comment:5 Changed 10 years ago by Adam Peller

Resolution: fixed
Status: reopenedclosed

(In [21789]) one more null condition. Fixes #10963 !strict

Note: See TracTickets for help on using tickets.