Opened 10 years ago

Closed 10 years ago

Last modified 8 years ago

#10949 closed defect (fixed)

dijit.form.CheckBox doesn't update UI on priority change

Reported by: childsb@… Owned by: bill
Priority: high Milestone: 1.5
Component: Dijit - Form Version: 1.4.1
Keywords: Cc:
Blocked By: Blocking:

Description

when doing a .attr("checked", true, false) on a checkbox, the 3rd 'priority change' argument prevents the state calculation + css class manipulation from occuring.

root cause (_CssStateMixin.js postCreate method):

this.connect(this, "attr", function(name, value){

if(arguments.length == 2 && {disabled: true, readOnly: true, checked:true, selected:true}[name]){

this._setStateClass();

}

});


with a priorityChange argument, the arguments.length==3, so this should be if(arguments.length>=2...)

see attached fix.

Attachments (1)

_CssStateMixin.js_patch (880 bytes) - added by childsb@… 10 years ago.
patch to _CssStateMixin

Download all attachments as: .zip

Change History (4)

Changed 10 years ago by childsb@…

Attachment: _CssStateMixin.js_patch added

patch to _CssStateMixin

comment:1 Changed 10 years ago by bill

Component: GeneralDijit
Milestone: tbd1.5
Owner: changed from anonymous to bill
Status: newassigned

Makes sense, that code also needs to be updated as per Kris' get/set changes though.

comment:2 Changed 10 years ago by bill

Resolution: fixed
Status: assignedclosed

(In [21742]) Fixes #10949 !strict: dijit.form.CheckBox? doesn't update UI on priority change

comment:3 Changed 8 years ago by bill

Component: DijitDijit - Form
Note: See TracTickets for help on using tickets.