Opened 10 years ago

Closed 9 years ago

Last modified 9 years ago

#10933 closed defect (fixed)

TitlePane - Locked open title pane has no Keyboard focus

Reported by: evan Owned by: Becky Gibson
Priority: high Milestone: 1.5
Component: Accessibility Version: 1.4.2
Keywords: ibm claro test team Cc: bill@…, santilli@…
Blocked By: Blocking:

Description (last modified by bill)

From Pilar Torres(IBM Lucid Testing Team):

Testing Type: Accessibility (Keyboard)

  1. Open an affected Browser
  2. Go to dijit/tests/test_TitlePane.html?theme=lucid
  3. Press TAB key & go to 'Test #8: locked open title pane'

Actual Result : Test #8: locked open title pane has not Keyboard focus. If you are using keyboard you can not read Test #8.

Expected Result: For accessibiity a clear visual focus indicator should ber provided for all visible elements

Attachments (1)

10933.patch (767 bytes) - added by Becky Gibson 9 years ago.

Download all attachments as: .zip

Change History (10)

comment:1 Changed 10 years ago by evan

This is a common issue across themes, so if use dijit/tests/layout/test_TitlePane.html, this issue also exists.

comment:2 Changed 10 years ago by bill

Description: modified (diff)

Becky, what do you think? The claim that "If you are using keyboard you can not read Test #8." sounds wrong to me, why would you need keyboard focus to read something? Lots of things on the screen don't get focus, for example <h1> tags. There's no problem w/the screen reader for them.

comment:3 Changed 10 years ago by Becky Gibson

I agree, not everything will get keyboard focus, however, if I click on this with the mouse, title #8 does get focus. Since there is no way to change a locked open title pane, focus is not absolutely necessary. However, keyboard focus should match focus that is obtainable via the mouse.

comment:4 Changed 10 years ago by bill

Keywords: claro added; lucid removed

comment:5 Changed 10 years ago by bill

(In [21805]) Disable hover effect for non-toggleable TitlePanes. Still has the problem where clicking the title bar will (for some reason) focus it. Refs #10933 !strict

comment:6 Changed 9 years ago by Becky Gibson

Title is still getting focus because an onfocus handler is getting inherited which sets the focus state - although I haven't traced that back. The focus can be fixed with the attached patch - instead of setting tabindex=-1, tabindex must be removed completely for non-toggled title panes. However, I didn't check this in because when you click on the title the focus classes are also being set. That is probably the root of the issue so would like Bill to check it out.

Changed 9 years ago by Becky Gibson

Attachment: 10933.patch added

comment:7 Changed 9 years ago by Becky Gibson

Milestone: tbd1.5.1

Title is still getting focus because an onfocus handler is getting inherited which sets the focus state - although I haven't traced that back. The focus can be fixed with the attached patch - instead of setting tabindex=-1, tabindex must be removed completely for non-toggled title panes. However, I didn't check this in because when you click on the title the focus classes are also being set. That is probably the root of the issue so would like Bill to check it out.

comment:8 Changed 9 years ago by Adam Peller

Milestone: 1.5.11.5
Resolution: fixed
Status: newclosed

Fixed in [22357]

comment:9 Changed 9 years ago by bill

when you click on the title the focus classes are also being set.

This is not really an issue, it's just that the CSS class name "dijitTitlePaneFocus" is a misnomer. It means that the TitlePane is "active", because the user clicked it. Similar to how dijitSpinnerFocused gets applied to a spinner when the user presses the up/down arrows, even though they don't actually get focus.

Note: See TracTickets for help on using tickets.