Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#10930 closed defect (fixed)

EnhancedGrid editable cells not properly updating store items

Reported by: Karl Tiedt Owned by: Bryan Forbes
Priority: high Milestone: 1.5
Component: DojoX Grid Version: 1.4.2
Keywords: Cc: bittarman
Blocked By: Blocking:

Description

In dojox/grid/cells/_base.js lines126-128 the follow code returns a DIV when it appears that all code calling it typically expects a form node of some sort (input or select)

 		getEditNode: function(inRowIndex){
			return (this.getNode(inRowIndex) || 0).firstChild || 0;
		},

the proper location of the editoNode is getNode(idx).firstChild.firstChild (in every case Bittarman and I tested in his app)

Surely this breaks quite a few things with editable grids... and probably needs fixing ASAP.

Change History (4)

comment:1 Changed 9 years ago by evan

This is already fixed in latest dojo nightly trunk targeting 1.5 by http://bugs.dojotoolkit.org/changeset/21664

comment:2 Changed 9 years ago by bill

Milestone: tbd1.5
Resolution: fixed
Status: newclosed

comment:3 Changed 9 years ago by Karl Tiedt

Evan, what exactly in [21664] fixes this? None of the files touched change anything that appears to even relate to this?

comment:4 Changed 9 years ago by bill

Owner: changed from bryanforbes to Bryan Forbes
Note: See TracTickets for help on using tickets.