Opened 9 years ago

Closed 8 years ago

Last modified 8 years ago

#10925 closed defect (fixed)

dojox.layout.TableContainer doesn't propagate resize()

Reported by: Sam Foster Owned by: Sam Foster
Priority: high Milestone: 1.6
Component: DojoX Layout Version: 1.4.0
Keywords: Cc:
Blocked By: Blocking:

Description

Because TableContainer? puts its children inside TD elements, the DOM query used by getChildren doesnt find them. As a result, resize is not propagated down to any child layout widgets.

I'm attaching a revised test page that demonstrates the problem.

Attachments (2)

test_TableContainer.html (14.0 KB) - added by Sam Foster 9 years ago.
[CLA] Test page illustrating resize/getChildren issue.
TableContainer-getChildren.patch (4.4 KB) - added by Sam Foster 9 years ago.
[CLA] [PATCH] getChildren override and extended test page to verify resize is propagated to child widgets

Download all attachments as: .zip

Change History (7)

Changed 9 years ago by Sam Foster

Attachment: test_TableContainer.html added

[CLA] Test page illustrating resize/getChildren issue.

Changed 9 years ago by Sam Foster

[CLA] [PATCH] getChildren override and extended test page to verify resize is propagated to child widgets

comment:1 Changed 9 years ago by Sam Foster

Owner: changed from dante to Sam Foster
Status: newassigned

Shane, unless you have comments, I'll go ahead and commit this.

comment:2 Changed 9 years ago by bill

Component: DojoX WidgetsDojoX Layout

comment:3 Changed 8 years ago by Sam Foster

(In [23660]) Adding resize test case, to confirm propagationt to TableContainer?'s children. Refs #10925

comment:4 Changed 8 years ago by Sam Foster

Resolution: fixed
Status: assignedclosed

This was actually fixed in some recent-ish work in dijit._Widget's getChildren and dijit.findWidget which now does the right thing in finding the child widgets, regardless of them being immediate child nodes. I've added a (monkey-do) test to confirm and track the behavior going forward.

comment:5 Changed 8 years ago by bill

Milestone: tbd1.6

bulk update: bugs fixed in past few months, presumably milestone is 1.6

Note: See TracTickets for help on using tickets.