Opened 9 years ago
Closed 9 years ago
#10924 closed defect (fixed)
Circular reference between dijit._editor._Plugin and dijit.Editor
| Reported by: | Rob Retchless | Owned by: | bill |
|---|---|---|---|
| Priority: | high | Milestone: | 1.5 |
| Component: | Dijit | Version: | 1.4.0 |
| Keywords: | Cc: | mpawlow | |
| Blocked By: | Blocking: |
Description
In our product, we analyze dependencies into a graph and send down bundled code in one request. Our tooling is flagging this circular dependency in our error logs.
- dijit._editor._Plugin requires dijit.Editor
- dijit.Editor requires dijit._editor._Plugin
Is there a reason why this is needed? It doesn't look like _Plugin needs to require dijit.Editor since it's created externally and injected at instantiation time or with setEditor.
Change History (3)
comment:1 Changed 9 years ago by
| Cc: | mpawlow added |
|---|
comment:2 Changed 9 years ago by
| Milestone: | tbd → 1.5 |
|---|---|
| Owner: | set to bill |
| Status: | new → assigned |
comment:3 Changed 9 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
Note: See
TracTickets for help on using
tickets.
Looks like you are right, it's unneeded, I'll remove it.