Opened 9 years ago

Closed 9 years ago

Last modified 8 years ago

#10902 closed defect (fixed)

[patch] [cla] Checkbox's setValueAttr doesn't respect priorityChange

Reported by: Dustin Machi Owned by:
Priority: high Milestone: 1.5
Component: Dijit - Form Version: 1.4.2
Keywords: Cc: childsb@…, Douglas Hays
Blocked By: Blocking:

Description

Most of the form widgets now support a third parameter to .attr('value', val, priorty) which allows you to prevent triggering onChange() essentially. This exists for doing attr("checked"), which is what attr('value') ultimately calls. Here is a small patch to allow the priority change attribute from _setValueAttr to be passed through to setCheckedAttr.

​http://dmachi.dojotoolkit.org/CheckBox_priorityChange.patch

Change History (5)

comment:1 Changed 9 years ago by Adam Peller

Cc: childsb@… added
Component: General → Dijit
Owner: anonymous deleted

comment:2 Changed 9 years ago by bill

Cc: Douglas Hays added
Summary: Checkbox's setValueAttr doesn't respect priorityChange → [patch] [cla] Checkbox's setValueAttr doesn't respect priorityChange

Looks good to me, Doug do you see any problems?

comment:3 Changed 9 years ago by Douglas Hays

That'll work

comment:4 Changed 9 years ago by bill

Resolution: → fixed
Status: new → closed

(In [21874]) Apply Dustin's fix so priorityChange works when set("value", ...) is used to adjust the checked/unchecked state. Fixes #10902 !strict.

comment:5 Changed 8 years ago by bill

Component: Dijit → Dijit - Form
Note: See TracTickets for help on using tickets.