i18nUtil.flattenLayerFileBundles regular expression not general enough

[yveskurz]

In "util/trunk/buildscripts/jslib/i18nUtil.js" function "flattenLayerFileBundles()" is a regular expression which should match all calls to dojo.requireLocalization(). This regular expression can be improved by allowing whitespace characters between function name its arguments and the semicolon.

Current regular expression:

var requireStatements = fileContents.match(/dojo\.requireLocalization\(.*\)\;/g);

More flexible expression:

var requireStatements = fileContents.match(/dojo\.requireLocalization\s*\(.*\)\s*\;/g);

This allows recognizing statements like: dojo.requireLocalization (...) ;

[bill]

(sadly) punting seemingly abandoned ticket and meta tickets to future

[bill]

Bulk update to assign BuildSystem? tickets to Rawld. Many of these are probably already fixed in 1.7.

[Rawld Gill]

The regex hell of the past can be completely circumvented by using AMD modules. That said, I'll take a look and fix if this particular regex is being used in any of the backcompat.

[Rawld Gill]

The algorithm for sniffing legacy loader API calls was improved in 1.7. The new algorithm

• does not use this regular expression
• handles spaces correctly

See the function extractLegacyApiApplications in dojo/_base\loader.js for details.