Opened 10 years ago

Closed 9 years ago

Last modified 9 years ago

#10874 closed defect (fixed)

Height of dojox.image.Lightbox should calculated and not harcoded

Reported by: minobun Owned by: dante
Priority: high Milestone: 1.6
Component: Dojox Version: 1.4.0
Keywords: Cc:
Blocked By: Blocking:

Description

The height of dojoxLightboxFooter is set to 30px in some cases:

		var adjustSize = dojo.boxModel == "border-box" ? 
			dojo._getBorderExtents(this.domNode).w : 0,
			titleSize = forceTitle || { h:30 }
		;

A change to this should fix it and should allow now bigger icons in the Footer:

		var adjustSize = dojo.boxModel == "border-box" ? 
			dojo._getBorderExtents(this.domNode).w : 0;
		var titleSize;
		if (forceTitle) {
			titleSize = forceTitle;
		}
		else {
			var nodeMaxHeight = 0;
			for (var i = 0;  i < this.titleNode.children.length;  i++)  {
				var nInfo = dojo.position(this.titleNode.childNodes[i]);
				if (nInfo['h'] > nodeMaxHeight) {
					nodeMaxHeight += nInfo['h'];
				}
			}
			titleSize = {h:nodeMaxHeight};
		} 

I first attached this to #7272 but #7272 has a very old version number (1.1.1) so please close #7272.

Change History (4)

comment:1 Changed 10 years ago by Adam Peller

Owner: changed from Adam Peller to dante

comment:2 Changed 10 years ago by Adam Peller

#7272 was apparently fixed in 1.4. I'll let Pete decide how to handle this.

comment:3 Changed 9 years ago by dante

Resolution: fixed
Status: newclosed

this is fixed as part of the reopening of #7272

comment:4 Changed 9 years ago by bill

Milestone: tbd1.6
Note: See TracTickets for help on using tickets.