Opened 10 years ago

Closed 9 years ago

#10856 closed enhancement (fixed)

[patch][ccla] Charting Animation for Zoom/Grow

Reported by: ruanqi Owned by: Eugene Lazutkin
Priority: high Milestone: 1.5
Component: Charting Version: 1.4.0
Keywords: charting, animation Cc: deanw@…, hwcdl@…, xiangxz@…
Blocked By: Blocking:

Description (last modified by Adam Peller)

FYI. this enhancement enable chart(area,lines,markers...) grow/zoom animation.

1.chart grows from the bottom when it render, set "animation" to turn it on. e.g.

chart.addPlot("default", {type: "Areas",animation:{duration:2000}}).render();

2.chart zooms by the scale&offset of axes, add a argument to turn it on. e.g.

chart.setWindow(scaleX, scaleY, offsetX, offsetY, {duration:1800}).render();

This patch also implements a "zoomIn" method in Chart2D, it supports chart zooming to a certain axis range. e.g.

chart.zoomIn("x",[50,80]);//chart zooms to 50-80 range on axis x

demo: test_axisZoomControl.html in the attachment.

Attachments (4)

chart-animate-zoom_20100318.patch (13.4 KB) - added by Adam Peller 10 years ago.
Enable chart grow/zoom animation, from ruanqi (IBM, CCLA)
chart-animate-zoom_20100322.patch (18.6 KB) - added by Adam Peller 10 years ago.
updated patch from ruanqi
chart-animate-zoom_20100414.patch (11.5 KB) - added by Adam Peller 9 years ago.
updated patch from zhouxiang
chart-animate-zoom_20100422.patch (22.8 KB) - added by bill 9 years ago.
updated patch from zhouxiang

Download all attachments as: .zip

Change History (25)

comment:1 Changed 10 years ago by Eugene Lazutkin

Status: newassigned

I assume your submission is covered by CLA/CCLA (IBM?). If it is so, please add to the summary [CCLA] prefix.

comment:2 Changed 10 years ago by Eugene Lazutkin

BTW, the demo link is behind the firewall --- can't use it.

comment:3 in reply to:  2 Changed 10 years ago by ruanqi

Replying to elazutkin:

BTW, the demo link is behind the firewall --- can't use it.

test_win2d.html in the attachment patch could took as a demo.

Changed 10 years ago by Adam Peller

Enable chart grow/zoom animation, from ruanqi (IBM, CCLA)

comment:4 Changed 10 years ago by Adam Peller

Description: modified (diff)
Summary: [patch] Charting Animation for Zoom/Grow[patch][ccla] Charting Animation for Zoom/Grow

Changed 10 years ago by Adam Peller

updated patch from ruanqi

comment:5 Changed 10 years ago by Adam Peller

Description: modified (diff)

comment:6 Changed 9 years ago by Adam Peller

Cc: hwcdl@… xiangxz@… added

comment:7 Changed 9 years ago by Eugene Lazutkin

This patch clashes with #10898. Need to reconcile. :-(

comment:8 in reply to:  7 ; Changed 9 years ago by JayZ(zhouxiang)

Replying to elazutkin:

This patch clashes with #10898. Need to reconcile. :-(

Maybe we can apply one change first, then the other one can prepare a new fresh patch based on the new trunk as it then stands, elazutkin, what do you think?

comment:9 in reply to:  8 Changed 9 years ago by davec

Replying to zhouxiang:

Maybe we can apply one change first, then the other one can prepare a new fresh patch based on the new trunk as it then stands, elazutkin, what do you think?

I think we should apply this patch and then work out what to do with #10898.

comment:10 in reply to:  8 ; Changed 9 years ago by Eugene Lazutkin

Replying to zhouxiang: Replying to davec:

Actually it clashes with the other massive patch in the pipeline. I'll see what I can do when it lands.

comment:11 in reply to:  10 ; Changed 9 years ago by Eugene Lazutkin

[21836] has landed. All plots were updated, and I cannot apply many patches mechanically even if I wanted to do so. Fear not, I'll merge it manually. Of course, if you have time on hands, you can update the patch to the current trunk saving me some time. ;-)

comment:12 in reply to:  11 Changed 9 years ago by JayZ(zhouxiang)

ok, I'll create a new patch based on the latest dojo trunk and ask adam to help me upload that patch, thank you.

Changed 9 years ago by Adam Peller

updated patch from zhouxiang

comment:13 Changed 9 years ago by Eugene Lazutkin

Resolution: fixed
Status: assignedclosed

(In [21862]) Animated zoom for the default plot from zhouxiang + tests, thx!, !strict, fixes #10856.

comment:14 Changed 9 years ago by Eugene Lazutkin

Action items:

  • Make sure that the animation enhancement API for the default plot matches the same API for the bar chart (or vice-versa). We cannot afford different APIs for the same functionality.
  • We need to extend the animation to other plot types. The default plot is arguably the most involved one, the rest are much easier.

comment:15 Changed 9 years ago by JayZ(zhouxiang)

Follow your action items, I make the animation works on bar chart and extend the animation to all the 2D plot types except for Pie chart. I've created a new patch for it and asked adam to upload it. Please check... thank you.

comment:16 in reply to:  15 Changed 9 years ago by Eugene Lazutkin

Replying to zhouxiang:

Follow your action items, I make the animation works on bar chart and extend the animation to all the 2D plot types except for Pie chart. I've created a new patch for it and asked adam to upload it. Please check... thank you.

Thank you for the initiative. Bar/column chart already has this functionality and I wanted to make sure that the API is the same.

You should be able to attach patches yourself, if not, you can send them to me directly, so I can do it. Unless, of course, you have some additional reasons to go through Adam.

comment:17 Changed 9 years ago by JayZ(zhouxiang)

Hi, elazutkin, IBM has a ossc process we should follow, we can not attach patches ourselves. Any code go outside should go through Adam.

comment:18 in reply to:  17 Changed 9 years ago by Eugene Lazutkin

Replying to zhouxiang:

Hi, elazutkin, IBM has a ossc process we should follow, we can not attach patches ourselves. Any code go outside should go through Adam.

Fair enough. Let's wait for Adam then.

comment:19 Changed 9 years ago by Eugene Lazutkin

Resolution: fixed
Status: closedreopened

comment:20 Changed 9 years ago by Eugene Lazutkin

test_win2d.html --- mouse dragging is broken in the test, should be calculated differently.

Changed 9 years ago by bill

updated patch from zhouxiang

comment:21 Changed 9 years ago by Eugene Lazutkin

Resolution: fixed
Status: reopenedclosed

(In [21916]) Implemented initial animation and zoom for all plot types, thx Zhou Xiang!, !strict, fixes #10856.

Note: See TracTickets for help on using tickets.