Opened 10 years ago

Closed 10 years ago

Last modified 8 years ago

#10840 closed defect (fixed)

make textbox widget width/height consistent

Reported by: bill Owned by: Douglas Hays
Priority: high Milestone: 1.5
Component: Dijit - Form Version: 1.4.0
Keywords: Cc:
Blocked By: Blocking:

Description

The texbox based widgets (TextBox, ValidationTextBox, NumberSpinner, ComboBox) etc. should be consistent in height, and also they should be consistent in width, assuming they have the same style="width: 123px; or CSS class setting their width.

Currently they are off by a few pixels (up to four pixels?).

See also http://www.sitepen.com/blog/2009/02/25/styling-dijit-form-elements/, although that is more about changing the width/height of form widgets than problems with width/height out of the box.

Change History (7)

comment:1 Changed 10 years ago by Douglas Hays

Resolution: fixed
Status: newclosed

(In [21560]) Fixes #10435, #10840 !strict. Tweak form/*TextBox? templates and CSS (including all dijit themes) so that they consistently render to the same height and width. Could not use a TABLE since WebKit? doesn't seem to support height:50% on a TD. Used an inner DIV with zoom:50% in IE to achieve the same height:50% effect. Added TextBox_sizes.html testcase to verify correct TextBox? subclass rendering. Added tests in dijit/form/module.js to test on all themes + RTL mode + quirks mode.

comment:2 Changed 10 years ago by Douglas Hays

(In [21561]) References #10435, #10840. Backout development test revision.

comment:3 Changed 10 years ago by bill

(In [21877]) fix tabbing and remove unneeded [], refs #10840

comment:4 Changed 10 years ago by bill

(In [21878]) just making test name match file name, so it's clearer in test output that these are sizing tests, refs #10840

comment:5 Changed 9 years ago by bill

(In [22669]) [21560] accidentally separated comment from it's related code, just moving comment, refs #10840 !strict.

Also removing with() usage since it's not supported in future versions of javascript, nor used elsewhere in dojo.

comment:6 Changed 9 years ago by bill

Component: DijitDijit - Form

comment:7 Changed 8 years ago by liucougar

In [26134]:

refs #10840: ignore invalid arguments error in IE when setting fontFamilty

this happens in some cases if textbox is used in dialog

Note: See TracTickets for help on using tickets.