Opened 10 years ago

Closed 9 years ago

Last modified 8 years ago

#10836 closed defect (fixed)

[cla][patch][regression] dojox.widget.Wizard does not initialize correctly when in a ContentPane

Reported by: jbarzilai Owned by: dante
Priority: high Milestone: 1.6
Component: DojoX Widgets Version: 1.4.0
Keywords: Cc: cjolif
Blocked By: Blocking:

Description

I found an issue with the dojox.widget.Wizard having to do with the new 1.4 startup code in the ContentPane. The Wizard currently initializes its buttons (by calling _checkButtons) in startup. This worked in pre-1.4 and when the Wizard was immediately visible, however in the case when the Wizard is in a ContentPane it does not work.

The error is caused when the _checkButtons method of Wizard.js is called before the _showChild method of StackContainer.js. _showChild initializes the isFirstChild and isLastChild attributes so it needs to be called before _checkButtons.

The patch I've attached should accomplish this.

The two test cases I've attached show the correct behavior (test_wizard.html) where the previous button is disabled and the next button works and the broken behavior (test_wizard_in_BC.html).

Attachments (3)

test_wizard.html (1.2 KB) - added by jbarzilai 10 years ago.
test_wizard_in_BC.html (1.5 KB) - added by jbarzilai 10 years ago.
Wizard.patch (985 bytes) - added by jbarzilai 10 years ago.

Download all attachments as: .zip

Change History (7)

Changed 10 years ago by jbarzilai

Attachment: test_wizard.html added

Changed 10 years ago by jbarzilai

Attachment: test_wizard_in_BC.html added

Changed 10 years ago by jbarzilai

Attachment: Wizard.patch added

comment:1 Changed 10 years ago by oakbehringer

Yup, this works. Thank you.

comment:2 Changed 9 years ago by dante

Milestone: tbd1.6
Status: newassigned

comment:3 Changed 9 years ago by dante

Resolution: fixed
Status: assignedclosed

(In [22723]) fixes #10836 - added dialog test and merged small patch from jbarzilai - thanks!

comment:4 Changed 8 years ago by cjolif

Cc: cjolif added
Note: See TracTickets for help on using tickets.