Opened 10 years ago

Closed 10 years ago

#10818 closed defect (invalid)

dijit.tree.TreeStoreModel.onNewItem uses parentInfo in the wrong way

Reported by: coa Owned by:
Priority: high Milestone: tbd
Component: Dijit Version: 1.4.0
Keywords: tree, TreeStoreModel, onNew, parentInfo Cc:
Blocked By: Blocking:

Description

The last three lines:

this.getChildren(parentInfo.item, dojo.hitch(this, function(children){
	this.onChildrenChange(parentInfo.item, children);
}));

...should be changed into:

this.getChildren(parentInfo.parent, dojo.hitch(this, function(children){
	this.onChildrenChange(parentInfo.parent, children);
}));

Change History (3)

comment:1 Changed 10 years ago by bill

Hmm, I'm not so sure. Can you provide a test case? Our existing tree tests are working.

comment:2 Changed 10 years ago by coa

Ah, interesting.

The form of parentInfo in newItem is

{parent, attribute}

but most stores (e.g. ItemFileWriteStore?, AndOrWriteStore?, XmlStore?) change it into

{item, attribute}

before passing it to onNew

(JsonRestStore? ignores it completely and sends null - see #10706, #9801)

I suppose this ticket should be marked as invalid.

comment:3 Changed 10 years ago by bill

Resolution: invalid
Status: newclosed

OK, that explains it then, sorry it's confusing like that.

Note: See TracTickets for help on using tickets.